Fix inputs validation warning, fix post step display name, fix worker crash due to error in step.env (#490)

src/Runner.Worker/ActionRunner.cs

@@ -94,6 +94,13 @@ namespace GitHub.Runner.Worker
             if (handlerData.HasPost && (Stage == ActionRunStage.Pre || Stage == ActionRunStage.Main))
             {
                 string postDisplayName = $"Post {this.DisplayName}";
+                if (Stage == ActionRunStage.Pre &&
+                    this.DisplayName.StartsWith("Pre ", StringComparison.OrdinalIgnoreCase))
+                {
+                    // Trim the leading `Pre ` from the display name.
+                    // Otherwise, we will get `Post Pre xxx` as DisplayName for the Post step.
+                    postDisplayName = $"Post {this.DisplayName.Substring("Pre ".Length)}";
+                }
                 var repositoryReference = Action.Reference as RepositoryPathReference;
                 var pathString = string.IsNullOrEmpty(repositoryReference.Path) ? string.Empty : $"/{repositoryReference.Path}";
                 var repoString = string.IsNullOrEmpty(repositoryReference.Ref) ? $"{repositoryReference.Name}{pathString}" :
@@ -155,6 +162,13 @@ namespace GitHub.Runner.Worker
             }
 
             var validInputs = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
+            if (handlerData.ExecutionType == ActionExecutionType.Container)
+            {
+                // container action always accept 'entryPoint' and 'args' as inputs
+                // https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepswithargs
+                validInputs.Add("entryPoint");
+                validInputs.Add("args");
+            }
             // Merge the default inputs from the definition
             if (definition.Data?.Inputs != null)
             {

src/Runner.Worker/ExecutionContext.cs

@@ -364,7 +364,11 @@ namespace GitHub.Runner.Worker
                 }
             }
 
+            if (Root != this)
+            {
+                // only dispose TokenSource for step level ExecutionContext 
                 _cancellationTokenSource?.Dispose();
+            }
 
             _logger.End();
 

src/Runner.Worker/JobRunner.cs

@@ -254,6 +254,12 @@ namespace GitHub.Runner.Worker
                     Trace.Error(ex);
                     return TaskResult.Failed;
                 }
+                catch (TaskOrchestrationPlanTerminatedException ex)
+                {
+                    Trace.Error($"TaskOrchestrationPlanTerminatedException received, while attempting to raise JobCompletedEvent for job {message.JobId}.");
+                    Trace.Error(ex);
+                    return TaskResult.Failed;
+                }
                 catch (Exception ex)
                 {
                     Trace.Error($"Catch exception while attempting to raise JobCompletedEvent for job {message.JobId}, job request {message.RequestId}.");

src/Runner.Worker/StepsRunner.cs

@@ -98,11 +98,14 @@ namespace GitHub.Runner.Worker
                         envContext[pair.Key] = new StringContextData(pair.Value ?? string.Empty);
                     }
 
+                    bool evaluateStepEnvFailed = false;
                     if (step is IActionRunner actionStep)
                     {
                         // Set GITHUB_ACTION
                         step.ExecutionContext.SetGitHubContext("action", actionStep.Action.Name);
 
+                        try
+                        {
                             // Evaluate and merge action's env block to env context
                             var templateEvaluator = step.ExecutionContext.ToPipelineTemplateEvaluator();
                             var actionEnvironment = templateEvaluator.EvaluateStepEnvironment(actionStep.Action.Environment, step.ExecutionContext.ExpressionValues, step.ExecutionContext.ExpressionFunctions, VarUtil.EnvironmentVariableKeyComparer);
@@ -111,7 +114,18 @@ namespace GitHub.Runner.Worker
                                 envContext[env.Key] = new StringContextData(env.Value ?? string.Empty);
                             }
                         }
+                        catch (Exception ex)
+                        {
+                            // fail the step since there is an evaluate error.
+                            Trace.Info("Caught exception from expression for step.env");
+                            evaluateStepEnvFailed = true;
+                            step.ExecutionContext.Error(ex);
+                            CompleteStep(step, nextStep, TaskResult.Failed);
+                        }
+                    }
 
+                    if (!evaluateStepEnvFailed)
+                    {
                         try
                         {
                             // Register job cancellation call back only if job cancellation token not been fire before each step run
@@ -219,6 +233,7 @@ namespace GitHub.Runner.Worker
                             }
                         }
                     }
+                }
 
                 // Update the job result.
                 if (step.ExecutionContext.Result == TaskResult.Failed)

src/runnerversion

@@ -1 +1 @@
-2.262.0
+2.262.1