Run service: send more stuff as part of job completed (#2423)

* send more stuff as part of job completed

* feedback

* set only once

* feedback

* feedback

* fix test

* feedback

* nit: spacing

* nit: line

Co-authored-by: Tingluo Huang <tingluohuang@github.com>

---------

Co-authored-by: Tingluo Huang <tingluohuang@github.com>

src/Sdk/RSWebApi/Contracts/AcquireJobRequest.cs

@@ -0,0 +1,13 @@
+using System.Collections.Generic;
+using System.Runtime.Serialization;
+using GitHub.DistributedTask.WebApi;
+
+namespace GitHub.Actions.RunService.WebApi
+{
+    [DataContract]
+    public class AcquireJobRequest
+    {
+        [DataMember(Name = "streamId", EmitDefaultValue = false)]
+        public string StreamID { get; set; }
+    }
+}

src/Sdk/RSWebApi/Contracts/CompleteJobRequest.cs

@@ -0,0 +1,26 @@
+using System;
+using System.Collections.Generic;
+using System.Runtime.Serialization;
+using GitHub.DistributedTask.WebApi;
+
+namespace GitHub.Actions.RunService.WebApi
+{
+    [DataContract]
+    public class CompleteJobRequest
+    {
+        [DataMember(Name = "planId", EmitDefaultValue = false)]
+        public Guid PlanID { get; set; }
+        
+        [DataMember(Name = "jobId", EmitDefaultValue = false)]
+        public Guid JobID { get; set; }
+        
+        [DataMember(Name = "conclusion")]
+        public TaskResult Conclusion { get; set; }
+        
+        [DataMember(Name = "outputs", EmitDefaultValue = false)]
+        public Dictionary<string, VariableValue> Outputs { get; set; }   
+        
+        [DataMember(Name = "stepResults", EmitDefaultValue = false)]
+        public IList<StepResult> StepResults { get; set; }
+    }
+}

src/Sdk/RSWebApi/Contracts/StepResult.cs

@@ -0,0 +1,38 @@
+using System;
+using System.Runtime.Serialization;
+using System.Threading.Tasks;
+using GitHub.DistributedTask.WebApi;
+
+namespace GitHub.Actions.RunService.WebApi
+{
+    [DataContract]
+    public class StepResult
+    {
+        [DataMember(Name = "external_id", EmitDefaultValue = false)]
+        public Guid ExternalID { get; set; }
+
+        [DataMember(Name = "number", EmitDefaultValue = false)]
+        public int? Number { get; set; }
+
+        [DataMember(Name = "name", EmitDefaultValue = false)]
+        public string Name { get; set; }
+
+        [DataMember(Name = "status")]
+        public TimelineRecordState? Status { get; set; }
+
+        [DataMember(Name = "conclusion")]
+        public TaskResult? Conclusion { get; set; }
+
+        [DataMember(Name = "started_at", EmitDefaultValue = false)]
+        public DateTime? StartedAt { get; set; }
+
+        [DataMember(Name = "completed_at", EmitDefaultValue = false)]
+        public DateTime? CompletedAt { get; set; }
+
+        [DataMember(Name = "completed_log_url", EmitDefaultValue = false)]
+        public string CompletedLogURL { get; set; }
+
+        [DataMember(Name = "completed_log_lines", EmitDefaultValue = false)]
+        public long? CompletedLogLines { get; set; }
+    }
+}

src/Sdk/RSWebApi/RunServiceHttpClient.cs

@@ -1,15 +1,17 @@
-using System;
+using System;
+using System.Collections.Generic;
 using System.Net.Http;
 using System.Threading;
 using System.Threading.Tasks;
+using GitHub.DistributedTask.Pipelines;
+using GitHub.DistributedTask.WebApi;
 using GitHub.Services.Common;
 using GitHub.Services.OAuth;
 using GitHub.Services.WebApi;
 using Sdk.WebApi.WebApi;
 
-namespace GitHub.DistributedTask.WebApi
+namespace GitHub.Actions.RunService.WebApi
 {
-    [ResourceArea(TaskResourceIds.AreaId)]
     public class RunServiceHttpClient : RawHttpClientBase
     {
         public RunServiceHttpClient(
@@ -52,21 +54,21 @@ namespace GitHub.DistributedTask.WebApi
         {
         }
 
-        public Task<Pipelines.AgentJobRequestMessage> GetJobMessageAsync(
+        public Task<AgentJobRequestMessage> GetJobMessageAsync(
             Uri requestUri,
             string messageId,
             CancellationToken cancellationToken = default)
         {
             HttpMethod httpMethod = new HttpMethod("POST");
-            var payload = new {
+            var payload = new AcquireJobRequest
+            {
                 StreamID = messageId
             };
 
             requestUri = new Uri(requestUri, "acquirejob");
 
-            var payloadJson = JsonUtility.ToString(payload);
-            var requestContent = new StringContent(payloadJson, System.Text.Encoding.UTF8, "application/json");
-            return SendAsync<Pipelines.AgentJobRequestMessage>(
+            var requestContent = new ObjectContent<AcquireJobRequest>(payload, new VssJsonMediaTypeFormatter(true));
+            return SendAsync<AgentJobRequestMessage>(
                 httpMethod,
                 requestUri: requestUri,
                 content: requestContent,
@@ -77,18 +79,24 @@ namespace GitHub.DistributedTask.WebApi
             Uri requestUri,
             Guid planId,
             Guid jobId,
+            TaskResult result,
+            Dictionary<String, VariableValue> outputs,
+            IList<StepResult> stepResults,
             CancellationToken cancellationToken = default)
         {
             HttpMethod httpMethod = new HttpMethod("POST");
-            var payload = new {
-                PlanId = planId,
-                JobId = jobId
+            var payload = new CompleteJobRequest()
+            {
+                PlanID = planId,
+                JobID = jobId,
+                Conclusion = result,
+                Outputs = outputs,
+                StepResults = stepResults
             };
 
             requestUri = new Uri(requestUri, "completejob");
 
-            var payloadJson = JsonUtility.ToString(payload);
-            var requestContent = new StringContent(payloadJson, System.Text.Encoding.UTF8, "application/json");
+            var requestContent = new ObjectContent<CompleteJobRequest>(payload, new VssJsonMediaTypeFormatter(true));
             return SendAsync(
                 httpMethod,
                 requestUri,