actions/runner
1
0
Fork 0
mirror of https://github.com/actions/runner.git synced 2025-12-12 15:13:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable tty output from Docker Actions (#916)

Browse Source 
* Update DockerCommandManager.cs

* Update StepHost.cs

Co-authored-by: Tingluo Huang <tingluohuang@github.com>
This commit is contained in:
Joel Dickson
2021-01-22 10:35:57 +07:00
committed by GitHub
parent 239cc0d7ca
commit 5972bd0060
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Runner.Worker/Container/DockerCommandManager.cs
View File

@@ -197,7 +197,8 @@ namespace GitHub.Runner.Worker.Container
dockerOptions.Add($"--workdir {container.ContainerWorkDirectory}"); dockerOptions.Add($"--workdir {container.ContainerWorkDirectory}");
dockerOptions.Add($"--rm"); dockerOptions.Add($"--rm");
dockerOptions.Add($"-t");
foreach (var env in container.ContainerEnvironmentVariables) foreach (var env in container.ContainerEnvironmentVariables)
{ {
// e.g. -e MY_SECRET maps the value into the exec'ed process without exposing // e.g. -e MY_SECRET maps the value into the exec'ed process without exposing

2
src/Runner.Worker/Handlers/StepHost.cs
View File

@@ -182,7 +182,7 @@ namespace GitHub.Runner.Worker.Handlers
dockerCommandArgs.Add($"exec"); dockerCommandArgs.Add($"exec");
// [OPTIONS] // [OPTIONS]
dockerCommandArgs.Add($"-i"); dockerCommandArgs.Add($"-it");
dockerCommandArgs.Add($"--workdir {workingDirectory}"); dockerCommandArgs.Add($"--workdir {workingDirectory}");
foreach (var env in environment) foreach (var env in environment)
{ {