Progress towards passing FileTable or FileID or FileName

This commit is contained in:
Ethan Chiu
2020-06-22 18:29:48 -04:00
parent 43a3006e7b
commit 58d11ef80a
7 changed files with 54 additions and 16 deletions

View File

@@ -137,9 +137,11 @@ namespace GitHub.DistributedTask.ObjectTemplating
Int32? fileId,
Int32? line,
Int32? column,
Exception ex)
Exception ex,
String fileName = default(string))
{
var prefix = GetErrorPrefix(fileId, line, column);
TraceWriter.Info($"Error fileId: {fileId}");
var prefix = GetErrorPrefix(fileId, line, column, fileName: fileName);
Errors.Add(prefix, ex);
TraceWriter.Error(prefix, ex);
}
@@ -203,9 +205,16 @@ namespace GitHub.DistributedTask.ObjectTemplating
private String GetErrorPrefix(
Int32? fileId,
Int32? line,
Int32? column)
Int32? column,
string fileName = default(string))
{
var fileName = fileId.HasValue ? GetFileName(fileId.Value) : null;
TraceWriter.Info($"GetErrorPrefix FileID: {fileId}");
// if (String.IsNullOrEmpty(fileName)) {
// fileName = fileId.HasValue ? GetFileName(fileId.Value) : null;
// }
// var fileName = fileId.HasValue ? GetFileName(fileId.Value) : null;
fileName = "TESTING";
if (!String.IsNullOrEmpty(fileName))
{
if (line != null && column != null)