diff --git a/src/Misc/layoutbin/update.sh.template b/src/Misc/layoutbin/update.sh.template index 668f91b23..42538cf24 100755 --- a/src/Misc/layoutbin/update.sh.template +++ b/src/Misc/layoutbin/update.sh.template @@ -161,59 +161,13 @@ if [[ "$currentplatform" == 'darwin' && restartinteractiverunner -eq 0 ]]; then date "+[%F %T-%4N] DarwinRunnerUpgrade: Failed to find runner path. Path: $path, pgid: $procgroup, root: $rootfolder" >> "$telemetryfile" 2>&1 fi else + runproc=$(ps x -o pgid,command | grep "run.sh" | grep -v grep | awk '{print $1}') + if [[ $? -eq 0 && -n "$runproc" ]] + then + date "+[%F %T-%4N] Running as ephemeral using run.sh, no need to recreate node folder" >> "$logfile" 2>&1 + else date "+[%F %T-%4N] DarwinRunnerUpgrade: Failed to find runner pgid. pgid: $procgroup, root: $rootfolder" >> "$logfile" 2>&1 date "+[%F %T-%4N] DarwinRunnerUpgrade: Failed to find runner pgid. pgid: $procgroup, root: $rootfolder" >> "$telemetryfile" 2>&1 - fi - - if [ $attemptedtargetedfix -eq 0 ] - then - - date "+[%F %T-%4N] DarwinRunnerUpgrade: Defaulting to old macOS service fix" >> "$logfile" 2>&1 - date "+[%F %T-%4N] DarwinRunnerUpgrade: Defaulting to old macOS service fix" >> "$telemetryfile" 2>&1 - if [[ ! -e "$rootfolder/externals.2.280.3/node12/bin/node" ]] - then - mkdir -p "$rootfolder/externals.2.280.3/node12/bin" - cp "$rootfolder/externals/node12/bin/node" "$rootfolder/externals.2.280.3/node12/bin/node" - fi - - if [[ ! -e "$rootfolder/externals.2.280.2/node12/bin/node" ]] - then - mkdir -p "$rootfolder/externals.2.280.2/node12/bin" - cp "$rootfolder/externals/node12/bin/node" "$rootfolder/externals.2.280.2/node12/bin/node" - fi - - if [[ ! -e "$rootfolder/externals.2.280.1/node12/bin/node" ]] - then - mkdir -p "$rootfolder/externals.2.280.1/node12/bin" - cp "$rootfolder/externals/node12/bin/node" "$rootfolder/externals.2.280.1/node12/bin/node" - fi - - # GHES 3.2 - if [[ ! -e "$rootfolder/externals.2.279.0/node12/bin/node" ]] - then - mkdir -p "$rootfolder/externals.2.279.0/node12/bin" - cp "$rootfolder/externals/node12/bin/node" "$rootfolder/externals.2.279.0/node12/bin/node" - fi - - # GHES 3.1.2 or later - if [[ ! -e "$rootfolder/externals.2.278.0/node12/bin/node" ]] - then - mkdir -p "$rootfolder/externals.2.278.0/node12/bin" - cp "$rootfolder/externals/node12/bin/node" "$rootfolder/externals.2.278.0/node12/bin/node" - fi - - # GHES 3.1.0 - if [[ ! -e "$rootfolder/externals.2.276.1/node12/bin/node" ]] - then - mkdir -p "$rootfolder/externals.2.276.1/node12/bin" - cp "$rootfolder/externals/node12/bin/node" "$rootfolder/externals.2.276.1/node12/bin/node" - fi - - # GHES 3.0 - if [[ ! -e "$rootfolder/externals.2.273.5/node12/bin/node" ]] - then - mkdir -p "$rootfolder/externals.2.273.5/node12/bin" - cp "$rootfolder/externals/node12/bin/node" "$rootfolder/externals.2.273.5/node12/bin/node" fi fi fi diff --git a/src/Runner.Listener/SelfUpdater.cs b/src/Runner.Listener/SelfUpdater.cs index 9aacf336c..399552169 100644 --- a/src/Runner.Listener/SelfUpdater.cs +++ b/src/Runner.Listener/SelfUpdater.cs @@ -75,11 +75,9 @@ namespace GitHub.Runner.Listener Trace.Info($"All running job has exited."); // We need to keep runner backup around for macOS until we fixed https://github.com/actions/runner/issues/743 -#if !OS_OSX // delete runner backup DeletePreviousVersionRunnerBackup(token); Trace.Info($"Delete old version runner backup."); -#endif // generate update script from template await UpdateRunnerUpdateStateAsync("Generate and execute update script.");