From 522fbd0546e310ddf8a3d52f42cde49025adab35 Mon Sep 17 00:00:00 2001 From: Ethan Chiu Date: Tue, 21 Jul 2020 17:46:51 -0400 Subject: [PATCH] Remove todos --- src/Runner.Worker/Handlers/ScriptHandler.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Runner.Worker/Handlers/ScriptHandler.cs b/src/Runner.Worker/Handlers/ScriptHandler.cs index f7d90dc45..d4bc492a2 100644 --- a/src/Runner.Worker/Handlers/ScriptHandler.cs +++ b/src/Runner.Worker/Handlers/ScriptHandler.cs @@ -151,8 +151,6 @@ namespace GitHub.Runner.Worker.Handlers string workingDirectory = null; if (!Inputs.TryGetValue("workingDirectory", out workingDirectory)) { - // TODO: figure out how defaults interact with template later - // for now, we won't check job.defaults if we are inside a template. if (string.IsNullOrEmpty(ExecutionContext.ScopeName) && ExecutionContext.Global.JobDefaults.TryGetValue("run", out var runDefaults)) { if (runDefaults.TryGetValue("working-directory", out workingDirectory)) @@ -167,8 +165,6 @@ namespace GitHub.Runner.Worker.Handlers string shell = null; if (!Inputs.TryGetValue("shell", out shell) || string.IsNullOrEmpty(shell)) { - // TODO: figure out how defaults interact with template later - // for now, we won't check job.defaults if we are inside a template. if (string.IsNullOrEmpty(ExecutionContext.ScopeName) && ExecutionContext.Global.JobDefaults.TryGetValue("run", out var runDefaults)) { if (runDefaults.TryGetValue("shell", out shell))