diff --git a/src/Runner.Worker/ActionManager.cs b/src/Runner.Worker/ActionManager.cs index 5a4345aee..b224743f6 100644 --- a/src/Runner.Worker/ActionManager.cs +++ b/src/Runner.Worker/ActionManager.cs @@ -402,7 +402,6 @@ namespace GitHub.Runner.Worker Trace.Verbose($"Details: {StringUtil.ConvertToJson(compositeAction.Steps)}"); Trace.Info($"Load: {compositeAction.Environment} environment steps"); Trace.Info($"Details: {StringUtil.ConvertToJson(compositeAction.Environment)}"); - Trace.Info($"Composite Action File ID: {compositeAction.FileID.ToString()}"); } else { @@ -1291,7 +1290,6 @@ namespace GitHub.Runner.Worker public override bool HasPost => false; public List Steps { get; set; } public MappingToken Environment { get; set; } - public Int32 FileID { get; set; } } public abstract class ActionExecutionData diff --git a/src/Runner.Worker/ActionManifestManager.cs b/src/Runner.Worker/ActionManifestManager.cs index 3dce12325..6cd05081a 100644 --- a/src/Runner.Worker/ActionManifestManager.cs +++ b/src/Runner.Worker/ActionManifestManager.cs @@ -27,7 +27,7 @@ namespace GitHub.Runner.Worker Dictionary EvaluateContainerEnvironment(IExecutionContext executionContext, MappingToken token, IDictionary extraExpressionValues); - public Dictionary EvaluateCompositeActionEnvironment(IExecutionContext executionContext, MappingToken token, IDictionary extraExpressionValues, Int32 fileID); + public Dictionary EvaluateCompositeActionEnvironment(IExecutionContext executionContext, MappingToken token, IDictionary extraExpressionValues); string EvaluateDefaultInput(IExecutionContext executionContext, string inputName, TemplateToken token); } @@ -226,8 +226,7 @@ namespace GitHub.Runner.Worker public Dictionary EvaluateCompositeActionEnvironment( IExecutionContext executionContext, MappingToken token, - IDictionary extraExpressionValues, - Int32 fileID) + IDictionary extraExpressionValues) { var result = new Dictionary(StringComparer.OrdinalIgnoreCase); @@ -236,7 +235,7 @@ namespace GitHub.Runner.Worker var context = CreateContext(executionContext, extraExpressionValues); try { - var evaluateResult = TemplateEvaluator.Evaluate(context, "runs-env", token, 0, fileID, omitHeader: false); + var evaluateResult = TemplateEvaluator.Evaluate(context, "runs-env", token, 0, null, omitHeader: false); context.Errors.Check(); // Mapping @@ -484,8 +483,7 @@ namespace GitHub.Runner.Worker return new CompositeActionExecutionData() { Steps = stepsLoaded, - Environment = envComposite, - FileID = fileID + Environment = envComposite }; } } diff --git a/src/Runner.Worker/ExecutionContext.cs b/src/Runner.Worker/ExecutionContext.cs index b4af2d0cf..b49fab72b 100644 --- a/src/Runner.Worker/ExecutionContext.cs +++ b/src/Runner.Worker/ExecutionContext.cs @@ -275,7 +275,6 @@ namespace GitHub.Runner.Worker { // TODO: For UI purposes, look at figuring out how to condense steps in one node => maybe use the same previous GUID var newGuid = Guid.NewGuid(); - // TODO: maybe have to use record id to figure out the right place to place the error message? step.ExecutionContext = Root.CreateChild(newGuid, step.DisplayName, newGuid.ToString("N"), null, null); step.ExecutionContext.ExpressionValues["inputs"] = inputsData; diff --git a/src/Runner.Worker/Handlers/CompositeActionHandler.cs b/src/Runner.Worker/Handlers/CompositeActionHandler.cs index 0634ac20c..6dd02de41 100644 --- a/src/Runner.Worker/Handlers/CompositeActionHandler.cs +++ b/src/Runner.Worker/Handlers/CompositeActionHandler.cs @@ -54,7 +54,7 @@ namespace GitHub.Runner.Worker.Handlers // Add the composite action environment variables to each step. // If the key already exists, we override it since the composite action env variables will have higher precedence // Note that for each composite action step, it's environment variables will be set in the StepRunner automatically - var compositeEnvData = manifestManager.EvaluateCompositeActionEnvironment(ExecutionContext, Data.Environment, extraExpressionValues, Data.FileID); + var compositeEnvData = manifestManager.EvaluateCompositeActionEnvironment(ExecutionContext, Data.Environment, extraExpressionValues); var envData = new Dictionary(); // Copy over parent environment