From 2e0e8eb8224d7b9ca5eb296205221fdb5335152d Mon Sep 17 00:00:00 2001 From: Alberto Gimeno Date: Mon, 27 Jan 2020 00:40:06 +0100 Subject: [PATCH] Change prompt message when removing a runner (#303) * Change prompt message to be consistent with the UI/API * Update test --- src/Runner.Listener/CommandSettings.cs | 4 ++-- src/Test/L0/Listener/CommandSettingsL0.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Runner.Listener/CommandSettings.cs b/src/Runner.Listener/CommandSettings.cs index 8797d3bdc..07a6c334b 100644 --- a/src/Runner.Listener/CommandSettings.cs +++ b/src/Runner.Listener/CommandSettings.cs @@ -190,7 +190,7 @@ namespace GitHub.Runner.Listener { return GetArgOrPrompt( name: Constants.Runner.CommandLine.Args.Token, - description: "Enter runner deletion token:", + description: "Enter runner remove token:", defaultValue: string.Empty, validator: Validators.NonEmptyValidator); } @@ -291,7 +291,7 @@ namespace GitHub.Runner.Listener if (!string.IsNullOrEmpty(result)) { // After read the arg from input commandline args, remove it from Arg dictionary, - // This will help if bad arg value passed through CommandLine arg, when ConfigurationManager ask CommandSetting the second time, + // This will help if bad arg value passed through CommandLine arg, when ConfigurationManager ask CommandSetting the second time, // It will prompt for input instead of continue use the bad input. _trace.Info($"Remove {name} from Arg dictionary."); RemoveArg(name); diff --git a/src/Test/L0/Listener/CommandSettingsL0.cs b/src/Test/L0/Listener/CommandSettingsL0.cs index f5b5187a6..9ef40dd0c 100644 --- a/src/Test/L0/Listener/CommandSettingsL0.cs +++ b/src/Test/L0/Listener/CommandSettingsL0.cs @@ -498,7 +498,7 @@ namespace GitHub.Runner.Common.Tests _promptManager .Setup(x => x.ReadValue( Constants.Runner.CommandLine.Args.Token, // argName - "Enter runner deletion token:", // description + "Enter runner remove token:", // description true, // secret string.Empty, // defaultValue Validators.NonEmptyValidator, // validator