Remove Temporary Serialization Shim (#2549)

This commit is contained in:
John Wesley Walker III
2023-05-03 15:29:19 +02:00
committed by GitHub
parent 896152d78e
commit 229b9b8ecc
3 changed files with 2 additions and 10 deletions

View File

@@ -7,10 +7,5 @@ namespace GitHub.Actions.RunService.WebApi
{ {
[DataMember(Name = "jobMessageId", EmitDefaultValue = false)] [DataMember(Name = "jobMessageId", EmitDefaultValue = false)]
public string JobMessageId { get; set; } public string JobMessageId { get; set; }
// This field will be removed in an upcoming Runner release.
// It's left here temporarily to facilitate the transition to the new field name, JobMessageId.
[DataMember(Name = "streamId", EmitDefaultValue = false)]
public string StreamId { get; set; }
} }
} }

View File

@@ -65,7 +65,6 @@ namespace GitHub.Actions.RunService.WebApi
var payload = new AcquireJobRequest var payload = new AcquireJobRequest
{ {
JobMessageId = messageId, JobMessageId = messageId,
StreamId = messageId,
}; };
requestUri = new Uri(requestUri, "acquirejob"); requestUri = new Uri(requestUri, "acquirejob");

View File

@@ -14,11 +14,9 @@ public sealed class AcquireJobRequestL0
[Trait("Category", "Common")] [Trait("Category", "Common")]
public void VerifySerialization() public void VerifySerialization()
{ {
var jobMessageId = "1526919030369-33";
var request = new AcquireJobRequest var request = new AcquireJobRequest
{ {
JobMessageId = jobMessageId, JobMessageId = "1526919030369-33"
StreamId = jobMessageId
}; };
var serializer = new DataContractJsonSerializer(typeof(AcquireJobRequest)); var serializer = new DataContractJsonSerializer(typeof(AcquireJobRequest));
using var stream = new MemoryStream(); using var stream = new MemoryStream();
@@ -27,7 +25,7 @@ public sealed class AcquireJobRequestL0
stream.Position = 0; stream.Position = 0;
using var reader = new StreamReader(stream, Encoding.UTF8); using var reader = new StreamReader(stream, Encoding.UTF8);
string json = reader.ReadToEnd(); string json = reader.ReadToEnd();
string expected = DoubleQuotify(string.Format("{{'jobMessageId':'{0}','streamId':'{0}'}}", request.JobMessageId)); string expected = DoubleQuotify(string.Format("{{'jobMessageId':'{0}'}}", request.JobMessageId));
Assert.Equal(expected, json); Assert.Equal(expected, json);
} }