From 1b61d78c07af22165b8f563cf52181e8399668b4 Mon Sep 17 00:00:00 2001 From: Yang Cao Date: Wed, 17 Apr 2024 09:55:03 -0400 Subject: [PATCH] Relax the condition to stop uploading to Results (#3230) --- src/Runner.Common/JobServerQueue.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Runner.Common/JobServerQueue.cs b/src/Runner.Common/JobServerQueue.cs index 9c27bf51d..e489ff202 100644 --- a/src/Runner.Common/JobServerQueue.cs +++ b/src/Runner.Common/JobServerQueue.cs @@ -74,6 +74,7 @@ namespace GitHub.Runner.Common private readonly List _jobTelemetries = new(); private bool _queueInProcess = false; private bool _resultsServiceOnly = false; + private int _resultsServiceExceptionsCount = 0; private Stopwatch _resultsUploadTimer = new(); private Stopwatch _actionsUploadTimer = new(); @@ -579,9 +580,9 @@ namespace GitHub.Runner.Common Trace.Info("Catch exception during file upload to results, keep going since the process is best effort."); Trace.Error(ex); errorCount++; - + _resultsServiceExceptionsCount++; // If we hit any exceptions uploading to Results, let's skip any additional uploads to Results unless Results is serving logs - if (!_resultsServiceOnly) + if (!_resultsServiceOnly && _resultsServiceExceptionsCount > 3) { _resultsClientInitiated = false; SendResultsTelemetry(ex);