actions/runner
1
0
Fork 0
mirror of https://github.com/actions/runner.git synced 2025-12-12 15:13:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up trace messages + add Trace debug in ActionManager

Browse Source
This commit is contained in:
Ethan Chiu
2020-06-18 16:13:56 -04:00
parent 038e5e2c2e
commit 180a687f30
3 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Runner.Worker/ActionManager.cs
View File

@@ -397,7 +397,8 @@ namespace GitHub.Runner.Worker
} }
else if (definition.Data.Execution.ExecutionType == ActionExecutionType.Composite && !String.IsNullOrEmpty(Environment.GetEnvironmentVariable("TESTING_COMPOSITE_ACTIONS_ALPHA"))) else if (definition.Data.Execution.ExecutionType == ActionExecutionType.Composite && !String.IsNullOrEmpty(Environment.GetEnvironmentVariable("TESTING_COMPOSITE_ACTIONS_ALPHA")))
{ {
// Don't do anything for now var compositeAction = definition.Data.Execution as CompositeActionExecutionData;
Trace.Info($"Action steps: {compositeAction.Steps}.");
} }
else else
{ {

4
src/Runner.Worker/ExecutionContext.cs
View File

@@ -291,8 +291,6 @@ namespace GitHub.Runner.Worker
// placed after the queued composite steps // placed after the queued composite steps
// This will take only O(n+m) time which would be just as efficient if we refactored the code of JobSteps to a PriorityQueue // This will take only O(n+m) time which would be just as efficient if we refactored the code of JobSteps to a PriorityQueue
// This temp Queue is created in the CompositeActionHandler. // This temp Queue is created in the CompositeActionHandler.
Trace.Info("Adding Composite Action Step");
var newGuid = Guid.NewGuid(); var newGuid = Guid.NewGuid();
step.ExecutionContext = Root.CreateChild(newGuid, step.DisplayName, newGuid.ToString("N"), null, null); step.ExecutionContext = Root.CreateChild(newGuid, step.DisplayName, newGuid.ToString("N"), null, null);
step.ExecutionContext.ExpressionValues["inputs"] = inputsData; step.ExecutionContext.ExpressionValues["inputs"] = inputsData;
@@ -310,7 +308,6 @@ namespace GitHub.Runner.Worker
Root.JobSteps.Clear(); Root.JobSteps.Clear();
foreach (var cs in steps) foreach (var cs in steps)
{ {
Trace.Info($"EnqueueAllCompositeSteps : Adding Composite action step {cs}");
Root.JobSteps.Enqueue(cs); Root.JobSteps.Enqueue(cs);
} }
foreach (var s in temp) foreach (var s in temp)
@@ -323,7 +320,6 @@ namespace GitHub.Runner.Worker
Root.JobSteps = new Queue<IStep>(); Root.JobSteps = new Queue<IStep>();
foreach (var cs in steps) foreach (var cs in steps)
{ {
Trace.Info($"EnqueueAllCompositeSteps : Adding Composite action step {cs}");
Root.JobSteps.Enqueue(cs); Root.JobSteps.Enqueue(cs);
} }
} }

8
src/Runner.Worker/Handlers/CompositeActionHandler.cs
View File

@@ -36,14 +36,6 @@ namespace GitHub.Runner.Worker.Handlers
// Resolve action steps // Resolve action steps
var actionSteps = Data.Steps; var actionSteps = Data.Steps;
if (actionSteps == null)
{
Trace.Error("Data.Steps in CompositeActionHandler is null");
}
else
{
Trace.Info($"Data Steps Value for Composite Actions is: {actionSteps}.");
}
// Create Context Data to reuse for each composite action step // Create Context Data to reuse for each composite action step
var inputsData = new DictionaryContextData(); var inputsData = new DictionaryContextData();