From fdbe51d78cb3ebcc1a1fcdaadfdbfdb84dedf0cb Mon Sep 17 00:00:00 2001
From: sarathrajsrinivasan
 <159180023+sarathrajsrinivasan@users.noreply.github.com>
Date: Wed, 2 Oct 2024 07:38:03 -0700
Subject: [PATCH] [macOS] Fix automationmodetool and loginwindow issue for
 macOS14.7 (#10684)

---
 .../scripts/build/configure-autologin.sh      |  1 +
 .../macos/scripts/build/configure-machine.sh  | 33 ++++++++++---------
 .../macos/scripts/build/configure-system.sh   |  3 ++
 images/macos/templates/macOS-13.anka.pkr.hcl  |  1 +
 .../templates/macOS-13.arm64.anka.pkr.hcl     |  1 +
 images/macos/templates/macOS-14.anka.pkr.hcl  |  1 +
 .../templates/macOS-14.arm64.anka.pkr.hcl     |  1 +
 images/macos/templates/macOS-15.anka.pkr.hcl  |  2 ++
 .../templates/macOS-15.arm64.anka.pkr.hcl     |  1 +
 9 files changed, 29 insertions(+), 15 deletions(-)

diff --git a/images/macos/scripts/build/configure-autologin.sh b/images/macos/scripts/build/configure-autologin.sh
index 16bdc9242..004717490 100644
--- a/images/macos/scripts/build/configure-autologin.sh
+++ b/images/macos/scripts/build/configure-autologin.sh
@@ -9,6 +9,7 @@
 echo "Enabling automatic GUI login for the '$USERNAME' user.."
 python3 $HOME/bootstrap/kcpassword.py "$PASSWORD"
 /usr/bin/defaults write /Library/Preferences/com.apple.loginwindow autoLoginUser "$USERNAME"
+/usr/bin/defaults write /Library/Preferences/com.apple.loginwindow autoLoginUserScreenLocked -bool false
 
 : '
 The MIT License (MIT)
diff --git a/images/macos/scripts/build/configure-machine.sh b/images/macos/scripts/build/configure-machine.sh
index 438587fe9..abd1f9872 100644
--- a/images/macos/scripts/build/configure-machine.sh
+++ b/images/macos/scripts/build/configure-machine.sh
@@ -50,21 +50,18 @@ done
 rm -f ./add-certificate
 
 # enable-automationmode-without-authentication
-
+brew install expect
 retry=10
 while [[ $retry -gt 0 ]]; do
 {
-osascript <<EOF
-    tell application "Terminal"
-        activate
-        do script "automationmodetool enable-automationmode-without-authentication"
-        delay 2
-        tell application "System Events"
-            keystroke "${PASSWORD}"
-            keystroke return
-        end tell
-    end tell
-    delay 5
+    /usr/bin/expect <<EOF
+        spawn automationmodetool enable-automationmode-without-authentication
+        expect "password"
+        send "${PASSWORD}\r"
+        expect {
+            "succeeded." { puts "Automation mode enabled successfully"; exit 0 }
+            eof
+        }
 EOF
 } && break
 
@@ -77,9 +74,15 @@ EOF
 done
 
 echo "Getting terminal windows"
-term_service=$(launchctl list | grep -i terminal | cut -f3)
-echo "Close terminal windows: gui/501/${term_service}"
-launchctl bootout gui/501/${term_service} && sleep 5
+launchctl_output=$(launchctl list | grep -i terminal || true)
+
+if [ -n "$launchctl_output" ]; then
+    term_service=$(echo "$launchctl_output" | cut -f3)
+    echo "Close terminal windows: gui/501/${term_service}"
+    launchctl bootout gui/501/${term_service} && sleep 5
+else
+    echo "No open terminal windows found."
+fi
 
 # test enable-automationmode-without-authentication
 if [[ ! "$(automationmodetool)" =~ "DOES NOT REQUIRE" ]]; then
diff --git a/images/macos/scripts/build/configure-system.sh b/images/macos/scripts/build/configure-system.sh
index 344ae300d..23fd09f9e 100644
--- a/images/macos/scripts/build/configure-system.sh
+++ b/images/macos/scripts/build/configure-system.sh
@@ -50,3 +50,6 @@ sudo rm -f /usr/local/bin/invoke_tests
 
 # Clean Homebrew downloads
 sudo rm -rf /Users/$USER/Library/Caches/Homebrew/downloads/*
+
+# Uninstall expect used in configure-machine.sh
+brew uninstall expect
diff --git a/images/macos/templates/macOS-13.anka.pkr.hcl b/images/macos/templates/macOS-13.anka.pkr.hcl
index 9725cf435..352b1d896 100644
--- a/images/macos/templates/macOS-13.anka.pkr.hcl
+++ b/images/macos/templates/macOS-13.anka.pkr.hcl
@@ -178,6 +178,7 @@ build {
     execute_command  = "chmod +x {{ .Path }}; source $HOME/.bash_profile; sudo {{ .Vars }} {{ .Path }}"
     scripts          = [
       "${path.root}/../scripts/build/configure-tccdb-macos.sh",
+      "${path.root}/../scripts/build/configure-autologin.sh",
       "${path.root}/../scripts/build/configure-auto-updates.sh",
       "${path.root}/../scripts/build/configure-ntpconf.sh",
       "${path.root}/../scripts/build/configure-shell.sh"
diff --git a/images/macos/templates/macOS-13.arm64.anka.pkr.hcl b/images/macos/templates/macOS-13.arm64.anka.pkr.hcl
index a5aa126e9..238ab132e 100644
--- a/images/macos/templates/macOS-13.arm64.anka.pkr.hcl
+++ b/images/macos/templates/macOS-13.arm64.anka.pkr.hcl
@@ -179,6 +179,7 @@ build {
     execute_command  = "chmod +x {{ .Path }}; source $HOME/.bash_profile; sudo {{ .Vars }} {{ .Path }}"
     scripts          = [
       "${path.root}/../scripts/build/configure-tccdb-macos.sh",
+      "${path.root}/../scripts/build/configure-autologin.sh",
       "${path.root}/../scripts/build/configure-auto-updates.sh",
       "${path.root}/../scripts/build/configure-ntpconf.sh",
       "${path.root}/../scripts/build/configure-shell.sh"
diff --git a/images/macos/templates/macOS-14.anka.pkr.hcl b/images/macos/templates/macOS-14.anka.pkr.hcl
index 752583862..a29cd926b 100644
--- a/images/macos/templates/macOS-14.anka.pkr.hcl
+++ b/images/macos/templates/macOS-14.anka.pkr.hcl
@@ -178,6 +178,7 @@ build {
     execute_command  = "chmod +x {{ .Path }}; source $HOME/.bash_profile; sudo {{ .Vars }} {{ .Path }}"
     scripts          = [
       "${path.root}/../scripts/build/configure-tccdb-macos.sh",
+      "${path.root}/../scripts/build/configure-autologin.sh",
       "${path.root}/../scripts/build/configure-auto-updates.sh",
       "${path.root}/../scripts/build/configure-ntpconf.sh",
       "${path.root}/../scripts/build/configure-shell.sh"
diff --git a/images/macos/templates/macOS-14.arm64.anka.pkr.hcl b/images/macos/templates/macOS-14.arm64.anka.pkr.hcl
index 5a1a09274..be90e1015 100644
--- a/images/macos/templates/macOS-14.arm64.anka.pkr.hcl
+++ b/images/macos/templates/macOS-14.arm64.anka.pkr.hcl
@@ -180,6 +180,7 @@ build {
     execute_command  = "chmod +x {{ .Path }}; source $HOME/.bash_profile; sudo {{ .Vars }} {{ .Path }}"
     scripts          = [
       "${path.root}/../scripts/build/configure-tccdb-macos.sh",
+      "${path.root}/../scripts/build/configure-autologin.sh",
       "${path.root}/../scripts/build/configure-auto-updates.sh",
       "${path.root}/../scripts/build/configure-ntpconf.sh",
       "${path.root}/../scripts/build/configure-shell.sh"
diff --git a/images/macos/templates/macOS-15.anka.pkr.hcl b/images/macos/templates/macOS-15.anka.pkr.hcl
index 1bd3aefb3..6e93eccf2 100644
--- a/images/macos/templates/macOS-15.anka.pkr.hcl
+++ b/images/macos/templates/macOS-15.anka.pkr.hcl
@@ -174,6 +174,7 @@ build {
     execute_command  = "chmod +x {{ .Path }}; source $HOME/.bash_profile; sudo {{ .Vars }} {{ .Path }}"
     scripts          = [
       "${path.root}/../scripts/build/configure-tccdb-macos.sh",
+      "${path.root}/../scripts/build/configure-autologin.sh",
       "${path.root}/../scripts/build/configure-auto-updates.sh",
       "${path.root}/../scripts/build/configure-ntpconf.sh",
       "${path.root}/../scripts/build/configure-shell.sh"
@@ -201,6 +202,7 @@ build {
     execute_command  = "chmod +x {{ .Path }}; source $HOME/.bash_profile; {{ .Vars }} {{ .Path }}"
     pause_before     = "30s"
     scripts          = [
+      "${path.root}/../scripts/build/configure-windows.sh",
       "${path.root}/../scripts/build/install-powershell.sh",
       "${path.root}/../scripts/build/install-dotnet.sh",
       "${path.root}/../scripts/build/install-python.sh",
diff --git a/images/macos/templates/macOS-15.arm64.anka.pkr.hcl b/images/macos/templates/macOS-15.arm64.anka.pkr.hcl
index 50b34dcca..8e72eace0 100644
--- a/images/macos/templates/macOS-15.arm64.anka.pkr.hcl
+++ b/images/macos/templates/macOS-15.arm64.anka.pkr.hcl
@@ -176,6 +176,7 @@ build {
     execute_command  = "chmod +x {{ .Path }}; source $HOME/.bash_profile; sudo {{ .Vars }} {{ .Path }}"
     scripts          = [
       "${path.root}/../scripts/build/configure-tccdb-macos.sh",
+      "${path.root}/../scripts/build/configure-autologin.sh",
       "${path.root}/../scripts/build/configure-auto-updates.sh",
       "${path.root}/../scripts/build/configure-ntpconf.sh",
       "${path.root}/../scripts/build/configure-shell.sh"