[Windows] Implement installation helpers refactoring (#8865)

* [Windows] Refactor base Installer helper functions

* Fix helper name

* Fix name gen logic and improve error handling

* Fix hash checking logic

* Fix Install-VsixExtension invocation

* Fix variable name in Install-OpenSSL.ps1

* Fix type for git downloadUrl

images/windows/scripts/build/Install-Git.ps1

@@ -8,28 +8,25 @@ Import-Module "$env:ChocolateyInstall\helpers\chocolateyProfile.psm1"
 # Install the latest version of Git for Windows
 $repoURL = "https://api.github.com/repos/git-for-windows/git/releases/latest"
 $gitReleases = Invoke-RestMethod $repoURL
-[string]$downloadUrl = $gitReleases.assets.browser_download_url -match "Git-.+-64-bit.exe"
+$downloadUrl = $gitReleases.assets.browser_download_url -match "Git-.+-64-bit.exe" | Select-Object -First 1
+
 $installerFile = Split-Path $downloadUrl -Leaf
-$packagePath = Start-DownloadWithRetry -Url $downloadUrl -Name $installerFile
-
-#region Supply chain security - Git
-$fileHash = (Get-FileHash -Path $packagePath -Algorithm SHA256).Hash
 $externalHash = Get-HashFromGitHubReleaseBody -Url $RepoURL -FileName $installerFile
-Use-ChecksumComparison $fileHash $externalHash
-#endregion
 
-Install-Binary  -FilePath $packagePath `
-                -ArgumentList (
-                    "/VERYSILENT", `
-                    "/NORESTART", `
-                    "/NOCANCEL", `
-                    "/SP-", `
-                    "/CLOSEAPPLICATIONS", `
-                    "/RESTARTAPPLICATIONS", `
-                    "/o:PathOption=CmdTools", `
-                    "/o:BashTerminalOption=ConHost", `
-                    "/o:EnableSymlinks=Enabled", `
-                    "/COMPONENTS=gitlfs")
+Install-Binary `
+    -Url $downloadUrl `
+    -InstallArgs @(`
+        "/VERYSILENT", `
+        "/NORESTART", `
+        "/NOCANCEL", `
+        "/SP-", `
+        "/CLOSEAPPLICATIONS", `
+        "/RESTARTAPPLICATIONS", `
+        "/o:PathOption=CmdTools", `
+        "/o:BashTerminalOption=ConHost", `
+        "/o:EnableSymlinks=Enabled", `
+        "/COMPONENTS=gitlfs") `
+    -ExpectedSHA256Sum $externalHash
 
 Update-SessionEnvironment
 
@@ -42,7 +39,7 @@ git config --system --add safe.directory "*"
 Add-MachinePathItem "C:\Program Files\Git\bin"
 
 # Add well-known SSH host keys to ssh_known_hosts
-ssh-keyscan -t rsa,ecdsa,ed25519 github.com >> "C:\Program Files\Git\etc\ssh\ssh_known_hosts"
+ssh-keyscan -t rsa, ecdsa, ed25519 github.com >> "C:\Program Files\Git\etc\ssh\ssh_known_hosts"
 ssh-keyscan -t rsa ssh.dev.azure.com >> "C:\Program Files\Git\etc\ssh\ssh_known_hosts"
 
 Invoke-PesterTests -TestFile "Git"