From b392aa60bd82c390011176a683b606bf66ade2da Mon Sep 17 00:00:00 2001 From: Mikhail Timofeev <48208649+miketimofeev@users.noreply.github.com> Date: Wed, 9 Dec 2020 10:11:53 +0300 Subject: [PATCH] set parameters explicitly (#2221) --- images.CI/macos/destroy-vm.ps1 | 2 +- images.CI/macos/helpers.psm1 | 12 ++++++++++++ images.CI/macos/move-vm.ps1 | 2 +- images.CI/macos/select-datastore.ps1 | 2 +- 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/images.CI/macos/destroy-vm.ps1 b/images.CI/macos/destroy-vm.ps1 index f6ed1b1a8..774fa1115 100644 --- a/images.CI/macos/destroy-vm.ps1 +++ b/images.CI/macos/destroy-vm.ps1 @@ -39,7 +39,7 @@ param( Import-Module $PSScriptRoot\helpers.psm1 -DisableNameChecking # Connection to a vCenter Server system -Connect-VCServer +Connect-VCServer -VIServer $VIServer -VIUserName $VIUserName -VIPassword $VIPassword # Check vm clone status $chainId = (Get-VIEvent -Entity $VMName).ChainId diff --git a/images.CI/macos/helpers.psm1 b/images.CI/macos/helpers.psm1 index a5be3fee1..ddb09cd62 100644 --- a/images.CI/macos/helpers.psm1 +++ b/images.CI/macos/helpers.psm1 @@ -6,6 +6,18 @@ Helper functions to use in images.CI scripts Function Connect-VCServer { + [CmdletBinding()] + param( + [Parameter(Mandatory)] + [System.String]$VIUserName, + + [Parameter(Mandatory)] + [System.String]$VIPassword, + + [Parameter(Mandatory)] + [System.String]$VIServer + ) + try { # Preference diff --git a/images.CI/macos/move-vm.ps1 b/images.CI/macos/move-vm.ps1 index 37e839066..d94139877 100644 --- a/images.CI/macos/move-vm.ps1 +++ b/images.CI/macos/move-vm.ps1 @@ -46,7 +46,7 @@ param( Import-Module $PSScriptRoot\helpers.psm1 -DisableNameChecking # Connection to a vCenter Server system -Connect-VCServer +Connect-VCServer -VIServer $VIServer -VIUserName $VIUserName -VIPassword $VIPassword # Clear previously assigned tag with VM Name try { diff --git a/images.CI/macos/select-datastore.ps1 b/images.CI/macos/select-datastore.ps1 index 3daa0b39f..68bf4d9d3 100644 --- a/images.CI/macos/select-datastore.ps1 +++ b/images.CI/macos/select-datastore.ps1 @@ -99,7 +99,7 @@ function Select-DataStore { } # Connection to a vCenter Server system -Connect-VCServer +Connect-VCServer -VIServer $VIServer -VIUserName $VIUserName -VIPassword $VIPassword # Get a target datastore for current deployment Select-DataStore -VMName $VMName -TagCategory $TagCategory