From 8c7390a9605ed49690bc0854ee8cc5cbdb655a63 Mon Sep 17 00:00:00 2001 From: Daan De Meyer Date: Thu, 26 Dec 2019 21:08:07 +0100 Subject: [PATCH] Don't bloat the PATH when installing git Especially the mingw folder conflicts with other mingw installs. I don't think installing git should put a compiler on the PATH, especially since the Windows virtual environment by default already has a separate chocolatey mingw installed (at least according to the documentation). I'm not sure why the \bin and \usr\bin paths are put on the PATH manually since that should already be done by chocolatey so I removed those as well. Any pointers on how I can actually test these changes would be appreciated. --- images/win/scripts/Installers/Install-Git.ps1 | 3 --- 1 file changed, 3 deletions(-) diff --git a/images/win/scripts/Installers/Install-Git.ps1 b/images/win/scripts/Installers/Install-Git.ps1 index f8d2a2e7c..65f9f67a0 100644 --- a/images/win/scripts/Installers/Install-Git.ps1 +++ b/images/win/scripts/Installers/Install-Git.ps1 @@ -12,7 +12,4 @@ choco install git -y --package-parameters="/GitAndUnixToolsOnPath /WindowsTermin # Disable GCM machine-wide [Environment]::SetEnvironmentVariable("GCM_INTERACTIVE", "Never", [System.EnvironmentVariableTarget]::Machine) -Add-MachinePathItem "C:\Program Files\Git\mingw64\bin" -Add-MachinePathItem "C:\Program Files\Git\usr\bin" -Add-MachinePathItem "C:\Program Files\Git\bin" exit 0