actions/runner-images
1
0
Fork 0
mirror of https://github.com/actions/runner-images.git synced 2025-12-12 12:06:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add double quote escaping and update documentation (#7613)

Browse Source
This commit is contained in:
Shamil Mubarakshin
2023-05-18 07:26:10 +00:00
committed by GitHub
parent f2b1fa1399
commit 7e295782c3
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
docs/create-image-and-azure-resources.md
View File

@@ -57,7 +57,7 @@ In any case you will need these software installed:
``` ```
- [Az Powershell module](https://docs.microsoft.com/en-us/powershell/azure/install-az-ps). - [Az Powershell module](https://docs.microsoft.com/en-us/powershell/azure/install-az-ps).
Run this command in Powershell: Run this command in Powershell:
```powershell ```powershell
@@ -92,6 +92,11 @@ Finally, run `GenerateResourcesAndImage` function setting mandatory arguments: i
- `AzureLocation` - location where resources will be created (e.g. "East US") - `AzureLocation` - location where resources will be created (e.g. "East US")
- `ImageType` - what image to build (we suggest choosing "UbuntuMinimal" here, other valid options are "Windows2019", "Windows2022", "Ubuntu2004", "Ubuntu2204") - `ImageType` - what image to build (we suggest choosing "UbuntuMinimal" here, other valid options are "Windows2019", "Windows2022", "Ubuntu2004", "Ubuntu2204")
> :warning: When running `GenerateResourcesAndImage` in PowerShell 7.3, following command should be executed first:
> ```powershell
> $PSNativeCommandArgumentPassing = 'Legacy'
> ```
This function automatically creates all required Azure resources and kicks off packer image generation for the selected image type. This function automatically creates all required Azure resources and kicks off packer image generation for the selected image type.
When image is ready you may proceed to [deployment](#generated-machine-deployment) When image is ready you may proceed to [deployment](#generated-machine-deployment)

8
helpers/GenerateResourcesAndImage.ps1
View File

@@ -190,8 +190,8 @@ Function GenerateResourcesAndImage {
# Resource group names may contain special characters, that are not allowed in the storage account name # Resource group names may contain special characters, that are not allowed in the storage account name
$storageAccountName = $storageAccountName.Replace("-", "").Replace("_", "").Replace("(", "").Replace(")", "").ToLower() $storageAccountName = $storageAccountName.Replace("-", "").Replace("_", "").Replace("(", "").Replace(")", "").ToLower()
$storageAccountName += "001" $storageAccountName += "001"
# Storage Account Name can only be 24 characters long # Storage Account Name can only be 24 characters long
if ($storageAccountName.Length -gt 24){ if ($storageAccountName.Length -gt 24){
$storageAccountName = $storageAccountName.Substring(0, 24) $storageAccountName = $storageAccountName.Substring(0, 24)
@@ -266,10 +266,10 @@ Function GenerateResourcesAndImage {
$AgentIp = (Invoke-RestMethod http://ipinfo.io/json).ip $AgentIp = (Invoke-RestMethod http://ipinfo.io/json).ip
Write-Host "Restricting access to packer generated VM to agent IP Address: $AgentIp" Write-Host "Restricting access to packer generated VM to agent IP Address: $AgentIp"
} }
if ($builderScriptPath.Contains("pkr.hcl")) { if ($builderScriptPath.Contains("pkr.hcl")) {
if ($AgentIp) { if ($AgentIp) {
$AgentIp = '[ "{0}" ]' -f $AgentIp $AgentIp = '[ \"{0}\" ]' -f $AgentIp
} else { } else {
$AgentIp = "[]" $AgentIp = "[]"
} }