actions/runner-images
1
0
Fork 0
mirror of https://github.com/actions/runner-images.git synced 2025-12-12 12:06:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

report Tool nodes with null or empty versions (#8154)

Browse Source
This commit is contained in:
Mikhail Koliada
2023-08-24 18:40:20 +02:00
committed by GitHub
parent 5ff59cadc4
commit 37b9221f4d
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
helpers/software-report-base/SoftwareReport.Nodes.psm1
View File

@@ -161,6 +161,11 @@ class ToolVersionNode: BaseToolNode {
[String] $Version [String] $Version
ToolVersionNode([String] $ToolName, [String] $Version): base($ToolName) { ToolVersionNode([String] $ToolName, [String] $Version): base($ToolName) {
if ([String]::IsNullOrEmpty($Version)) {
throw "ToolVersionNode '$($this.ToolName)' has empty version"
}
$this.Version = $Version $this.Version = $Version
} }
@@ -196,6 +201,11 @@ class ToolVersionsListNode: BaseToolNode {
ToolVersionsListNode([String] $ToolName, [String[]] $Versions, [String] $MajorVersionRegex, [String] $ListType): base($ToolName) { ToolVersionsListNode([String] $ToolName, [String[]] $Versions, [String] $MajorVersionRegex, [String] $ListType): base($ToolName) {
$this.Versions = $Versions $this.Versions = $Versions
if ([String]::IsNullOrEmpty($Versions)) {
throw "ToolVersionsListNode '$($this.ToolName)' has empty versions list"
}
$this.MajorVersionRegex = [Regex]::new($MajorVersionRegex) $this.MajorVersionRegex = [Regex]::new($MajorVersionRegex)
$this.ListType = $ListType $this.ListType = $ListType
$this.ValidateMajorVersionRegex() $this.ValidateMajorVersionRegex()

2
helpers/software-report-base/tests/SoftwareReport.Nodes.Unit.Tests.ps1
View File

@@ -26,7 +26,7 @@ Describe "Nodes.UnitTests" {
It "Deserialization" { It "Deserialization" {
{ [ToolVersionNode]::FromJsonObject(@{ NodeType = "ToolVersionNode"; ToolName = ""; Version = "2.1.3" }) } | Should -Throw '*Exception setting "ToolName": "The argument is null or empty.*' { [ToolVersionNode]::FromJsonObject(@{ NodeType = "ToolVersionNode"; ToolName = ""; Version = "2.1.3" }) } | Should -Throw '*Exception setting "ToolName": "The argument is null or empty.*'
{ [ToolVersionNode]::FromJsonObject(@{ NodeType = "ToolVersionNode"; ToolName = "MyTool"; Version = "" }) } | Should -Throw '*Exception setting "Version": "The argument is null or empty.*' { [ToolVersionNode]::FromJsonObject(@{ NodeType = "ToolVersionNode"; ToolName = "MyTool"; Version = "" }) } | Should -Throw 'ToolVersionNode ''MyTool'' has empty version'
{ [ToolVersionNode]::FromJsonObject(@{ NodeType = "ToolVersionNode"; ToolName = "MyTool"; Version = "2.1.3" }) } | Should -Not -Throw { [ToolVersionNode]::FromJsonObject(@{ NodeType = "ToolVersionNode"; ToolName = "MyTool"; Version = "2.1.3" }) } | Should -Not -Throw
} }