[Ubuntu] Rewrite function download_with_retry (#8912)

* [Ubuntu] Rewrite function download_with_retry

* Fix loop exit condition

images/ubuntu/scripts/build/install-zstd.sh

@@ -10,19 +10,29 @@ source $HELPER_SCRIPTS/install.sh
 
 # Download zstd
 release_tag=$(curl -fsSL https://api.github.com/repos/facebook/zstd/releases/latest | jq -r '.tag_name')
-zstd_tar_name=zstd-${release_tag//v}.tar.gz
-URL=https://github.com/facebook/zstd/releases/download/${release_tag}/${zstd_tar_name}
-download_with_retries "${URL}" "/tmp" "${zstd_tar_name}"
+release_name="zstd-${release_tag//v}"
+download_url="https://github.com/facebook/zstd/releases/download/${release_tag}/${release_name}.tar.gz"
+archive_path=$(download_with_retry "${download_url}")
+
 # Supply chain security - zstd
-external_hash=$(get_hash_from_remote_file "${URL}.sha256" "${zstd_tar_name}")
-use_checksum_comparison "/tmp/${zstd_tar_name}" "${external_hash}"
+external_hash=$(get_hash_from_remote_file "${download_url}.sha256" "${release_name}.tar.gz")
+use_checksum_comparison "$archive_path" "$external_hash"
+
 # Install zstd
 apt-get install -y liblz4-dev
-tar xzf /tmp/$zstd_tar_name -C /tmp
-make -C /tmp/zstd-${release_tag//v}/contrib/pzstd all
-make -C /tmp/zstd-${release_tag//v} zstd-release
-for copyprocess in zstd zstdless zstdgrep; do cp /tmp/zstd-${release_tag//v}/programs/$copyprocess /usr/local/bin/; done
-cp /tmp/zstd-${release_tag//v}/contrib/pzstd/pzstd /usr/local/bin/
-for symlink in zstdcat zstdmt unzstd; do ln -sf /usr/local/bin/zstd /usr/local/bin/$symlink; done
+tar xzf "$archive_path" -C /tmp
+
+make -C "/tmp/${release_name}/contrib/pzstd" all
+make -C "/tmp/${release_name}" zstd-release
+
+for copyprocess in zstd zstdless zstdgrep; do
+  cp "/tmp/${release_name}/programs/${copyprocess}" /usr/local/bin/
+done
+
+cp "/tmp/${release_name}/contrib/pzstd/pzstd" /usr/local/bin/
+
+for symlink in zstdcat zstdmt unzstd; do
+  ln -sf /usr/local/bin/zstd /usr/local/bin/${symlink}
+done
 
 invoke_tests "Tools" "Zstd"