From 9cc623aaa951d7d141f399d84a54f0d87b0a8ca7 Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Tue, 25 Feb 2020 19:07:45 +0300 Subject: [PATCH] Add explanation why we use Azure DevOps CI --- images.CI/azure-pipelines/image-generation.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/images.CI/azure-pipelines/image-generation.yml b/images.CI/azure-pipelines/image-generation.yml index 0e20091f..7eeb555f 100644 --- a/images.CI/azure-pipelines/image-generation.yml +++ b/images.CI/azure-pipelines/image-generation.yml @@ -1,3 +1,9 @@ +# Currently, we use Azure DevOps for Images.CI as a temporary solution until GitHub Actions supports our requirements +# Since we have to use self-hosted machines to run image builds, we need the following features to use GitHub Actions for Images CI: +# - https://github.community/t5/GitHub-Actions/Make-secrets-available-to-builds-of-forks/m-p/30678#M508 +# - https://github.community/t5/GitHub-Actions/GitHub-Actions-Manual-Trigger-Approvals/td-p/31504 +# - https://github.community/t5/GitHub-Actions/Protecting-github-workflows/td-p/30290 + jobs: - job: pool: ci-agent-pool @@ -8,7 +14,7 @@ jobs: steps: - task: PowerShell@2 displayName: 'Download custom repository' - condition: and(ne(variables['CUSTOM_REPOSITORY_BRANCH'], ''), ne(variables['CUSTOM_REPOSITORY_URL'], '')) + condition: and(ne(variables['CUSTOM_REPOSITORY_URL'], ''), ne(variables['CUSTOM_REPOSITORY_BRANCH'], '')) inputs: targetType: 'inline' script: |