From 6637167579dc2135accf2098b0c804e29374710c Mon Sep 17 00:00:00 2001
From: Darleev <50947177+Darleev@users.noreply.github.com>
Date: Mon, 19 Jul 2021 09:29:53 +0100
Subject: [PATCH] [Ubuntu] Added HTTP status code check to
 download_with_retries (#3721)

* Disable exit on error temporary to implement retry logic based on exit code
* Check HTTP response code and retry if it's not 200
* Make variables local to not interfere with other scripts

Co-authored-by: Mikhail Timofeev <48208649+miketimofeev@users.noreply.github.com>
---
 images/linux/scripts/helpers/install.sh    | 27 ++++++++++++++--------
 images/linux/scripts/installers/graalvm.sh |  4 ++--
 2 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/images/linux/scripts/helpers/install.sh b/images/linux/scripts/helpers/install.sh
index efdfac54..0bf12071 100644
--- a/images/linux/scripts/helpers/install.sh
+++ b/images/linux/scripts/helpers/install.sh
@@ -14,22 +14,29 @@ download_with_retries() {
     local COMPRESSED="$4"
 
     if [[ $COMPRESSED == "compressed" ]]; then
-        COMMAND="curl $URL -4 -sL --compressed -o '$DEST/$NAME'"
+        local COMMAND="curl $URL -4 -sL --compressed -o '$DEST/$NAME' -w '%{http_code}'"
     else
-        COMMAND="curl $URL -4 -sL -o '$DEST/$NAME'"
+        local COMMAND="curl $URL -4 -sL -o '$DEST/$NAME' -w '%{http_code}'"
     fi
 
     echo "Downloading '$URL' to '${DEST}/${NAME}'..."
-    i=20
-    while [ $i -gt 0 ]; do
-        ((i--))
-        eval $COMMAND
-        if [ $? != 0 ]; then
-            sleep 30
-        else
+    retries=20
+    interval=30
+    while [ $retries -gt 0 ]; do
+        ((retries--))
+        # Temporary disable exit on error to retry on non-zero exit code
+        set +e
+        http_code=$(eval $COMMAND)
+        exit_code=$?
+        if [ $http_code -eq 200 ] && [ $exit_code -eq 0 ]; then
             echo "Download completed"
             return 0
+        else
+            echo "Error — Either HTTP response code for '$URL' is wrong - '$http_code' or exit code is not 0 - '$exit_code'. Waiting $interval seconds before the next attempt, $retries attempts left"
+            sleep 30
         fi
+        # Enable exit on error back
+        set -e
     done
 
     echo "Could not download $URL"
@@ -58,4 +65,4 @@ get_toolset_value() {
     local toolset_path=$(get_toolset_path)
     local query=$1
     echo "$(jq -r "$query" $toolset_path)"
-}
\ No newline at end of file
+}
diff --git a/images/linux/scripts/installers/graalvm.sh b/images/linux/scripts/installers/graalvm.sh
index 6d32344a..4026177a 100644
--- a/images/linux/scripts/installers/graalvm.sh
+++ b/images/linux/scripts/installers/graalvm.sh
@@ -7,7 +7,7 @@ source $HELPER_SCRIPTS/etc-environment.sh
 GRAALVM_ROOT=/usr/local/graalvm
 export GRAALVM_11_ROOT=$GRAALVM_ROOT/graalvm-ce-java11*
 
-url=$(curl -s https://api.github.com/repos/graalvm/graalvm-ce-builds/releases/latest | jq -r '.assets[].browser_download_url | select(contains("graalvm-ce-java11-linux-amd64"))')
+url=$(curl -s https://api.github.com/repos/graalvm/graalvm-ce-builds/releases/latest | jq -r '.assets[].browser_download_url | select(contains("graalvm-ce-java11-linux-amd64") and endswith("tar.gz"))')
 download_with_retries "$url" "/tmp" "graalvm-archive.tar.gz"
 mkdir $GRAALVM_ROOT
 tar -xzf "/tmp/graalvm-archive.tar.gz" -C $GRAALVM_ROOT
@@ -18,4 +18,4 @@ setEtcEnvironmentVariable "GRAALVM_11_ROOT" $GRAALVM_11_ROOT
 # Install Native Image
 $GRAALVM_11_ROOT/bin/gu install native-image
 
-invoke_tests "Tools" "GraalVM"
\ No newline at end of file
+invoke_tests "Tools" "GraalVM"