From 2123c3ae499326998b351ca1838be3d56207a57c Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Fri, 20 Mar 2020 13:46:12 +0300 Subject: [PATCH 1/7] Update templates --- .github/PULL_REQUEST_TEMPLATE/bug-fixing.md | 17 +++++++++++ .../PULL_REQUEST_TEMPLATE/new-tool-adding.md | 29 +++++++++++++++++++ 2 files changed, 46 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/bug-fixing.md create mode 100644 .github/PULL_REQUEST_TEMPLATE/new-tool-adding.md diff --git a/.github/PULL_REQUEST_TEMPLATE/bug-fixing.md b/.github/PULL_REQUEST_TEMPLATE/bug-fixing.md new file mode 100644 index 00000000..751c1075 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/bug-fixing.md @@ -0,0 +1,17 @@ +--- +name: Bug fixing and improvements +about: Fix existing bug with images or code improvements +title: '' +labels: '' +assignees: '' + +--- + +**Description** + +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. + +**Check list** +- [ ] non-breaking change which fixes an issue +- [ ] breaking change / regression +- [ ] Related images are successfully generated \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE/new-tool-adding.md b/.github/PULL_REQUEST_TEMPLATE/new-tool-adding.md new file mode 100644 index 00000000..86b282d9 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/new-tool-adding.md @@ -0,0 +1,29 @@ +--- +name: Add new tool +about: Add a new tool or update the existing one +title: Update/Add [tool name] +labels: '' +assignees: '' + +--- + +**Tool information** +- Tool name: +- URL for tool's homepage: +- Installation time: +- Total size: +- Related issue: + +**Virtual environments affected** +- [ ] macOS 10.15 +- [ ] Ubuntu 16.04 LTS +- [ ] Ubuntu 18.04 LTS +- [ ] Windows Server 2016 R2 +- [ ] Windows Server 2019 + +**Check list** +- [ ] Installation time is provided +- [ ] Tool size is provided +- [ ] Tests are written +- [ ] Documentation is added +- [ ] Related images are successfully generated \ No newline at end of file From c826d5af2625c3aaa36331dc9a1589676ef0a01b Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Fri, 20 Mar 2020 14:06:42 +0300 Subject: [PATCH 2/7] try --- .github/PULL_REQUEST_TEMPLATE/bug-fixing.md | 17 ----------------- ...-tool-adding.md => pull_request_template.md} | 9 ++------- 2 files changed, 2 insertions(+), 24 deletions(-) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/bug-fixing.md rename .github/{PULL_REQUEST_TEMPLATE/new-tool-adding.md => pull_request_template.md} (75%) diff --git a/.github/PULL_REQUEST_TEMPLATE/bug-fixing.md b/.github/PULL_REQUEST_TEMPLATE/bug-fixing.md deleted file mode 100644 index 751c1075..00000000 --- a/.github/PULL_REQUEST_TEMPLATE/bug-fixing.md +++ /dev/null @@ -1,17 +0,0 @@ ---- -name: Bug fixing and improvements -about: Fix existing bug with images or code improvements -title: '' -labels: '' -assignees: '' - ---- - -**Description** - -Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - -**Check list** -- [ ] non-breaking change which fixes an issue -- [ ] breaking change / regression -- [ ] Related images are successfully generated \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE/new-tool-adding.md b/.github/pull_request_template.md similarity index 75% rename from .github/PULL_REQUEST_TEMPLATE/new-tool-adding.md rename to .github/pull_request_template.md index 86b282d9..c4074af8 100644 --- a/.github/PULL_REQUEST_TEMPLATE/new-tool-adding.md +++ b/.github/pull_request_template.md @@ -1,11 +1,6 @@ ---- -name: Add new tool -about: Add a new tool or update the existing one -title: Update/Add [tool name] -labels: '' -assignees: '' +**Description** ---- +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. **Tool information** - Tool name: From 14e4c3e0413d6fad46cde60e6ff4454dbc2b8419 Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Mon, 23 Mar 2020 12:44:41 +0300 Subject: [PATCH 3/7] update template --- .github/pull_request_template.md | 30 +++++++++--------------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c4074af8..f6474e24 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,24 +1,12 @@ -**Description** +**Description** +New tool, Bug fixing, or Improvement? +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. +For new tools, provide total size and installation time. -Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - -**Tool information** -- Tool name: -- URL for tool's homepage: -- Installation time: -- Total size: -- Related issue: - -**Virtual environments affected** -- [ ] macOS 10.15 -- [ ] Ubuntu 16.04 LTS -- [ ] Ubuntu 18.04 LTS -- [ ] Windows Server 2016 R2 -- [ ] Windows Server 2019 +**Related issue:** **Check list** -- [ ] Installation time is provided -- [ ] Tool size is provided -- [ ] Tests are written -- [ ] Documentation is added -- [ ] Related images are successfully generated \ No newline at end of file +- [ ] Related issue / work item is attached +- [ ] Tests are written (if applicable) +- [ ] Documentation is updated (if applicable) +- [ ] Changes are tested and related VM images are succefully generated From 144081916b0180245c4fd1ff84cf7efcbc92b25d Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Mon, 23 Mar 2020 12:48:02 +0300 Subject: [PATCH 4/7] Update pull_request_template.md --- .github/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f6474e24..9c65c9a7 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,11 +1,11 @@ -**Description** +**Description:** New tool, Bug fixing, or Improvement? -Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. For new tools, provide total size and installation time. **Related issue:** -**Check list** +**Check list:** - [ ] Related issue / work item is attached - [ ] Tests are written (if applicable) - [ ] Documentation is updated (if applicable) From 60cfda73991c462ac484c2fb6c926c452777cc4e Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Mon, 23 Mar 2020 13:03:46 +0300 Subject: [PATCH 5/7] correct words --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9c65c9a7..2ee51fcc 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,7 +1,7 @@ **Description:** New tool, Bug fixing, or Improvement? -Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -For new tools, provide total size and installation time. +Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. +For new tools, please provide total size and installation time. **Related issue:** From dae1aa3be4f0b424b56b717a401c58bade51904f Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Mon, 23 Mar 2020 20:18:05 +0300 Subject: [PATCH 6/7] Update based on SergeyAkh comments --- .github/pull_request_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2ee51fcc..e645fafc 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,11 +1,11 @@ -**Description:** +# Description New tool, Bug fixing, or Improvement? Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. -For new tools, please provide total size and installation time. +**For new tools, please provide total size and installation time.** -**Related issue:** +#### Related issue: -**Check list:** +## Check list - [ ] Related issue / work item is attached - [ ] Tests are written (if applicable) - [ ] Documentation is updated (if applicable) From 62164dd90dc9d483aa1a329947398a60e615bdb7 Mon Sep 17 00:00:00 2001 From: Maxim Lobanov Date: Tue, 24 Mar 2020 08:09:54 +0300 Subject: [PATCH 7/7] fix spelling --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e645fafc..54085c9b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,4 +9,4 @@ Please include a summary of the change and which issue is fixed. Also include re - [ ] Related issue / work item is attached - [ ] Tests are written (if applicable) - [ ] Documentation is updated (if applicable) -- [ ] Changes are tested and related VM images are succefully generated +- [ ] Changes are tested and related VM images are successfully generated