From 2c37b60941011767418a359221810883009eb74d Mon Sep 17 00:00:00 2001 From: MaksimZhukov Date: Tue, 14 Jan 2020 13:13:55 +0300 Subject: [PATCH 1/4] Add ChromeWebDriver env variable --- images/linux/scripts/installers/google-chrome.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/images/linux/scripts/installers/google-chrome.sh b/images/linux/scripts/installers/google-chrome.sh index 9d6128f8..c37209b0 100644 --- a/images/linux/scripts/installers/google-chrome.sh +++ b/images/linux/scripts/installers/google-chrome.sh @@ -41,6 +41,7 @@ rm chromedriver_linux64.zip CHROMEDRIVER_BIN="/usr/bin/chromedriver" mv "chromedriver" $CHROMEDRIVER_BIN +echo "ChromeWebDriver=$CHROMEDRIVER_BIN" | tee -a /etc/environment chown root:root $CHROMEDRIVER_BIN chmod +x $CHROMEDRIVER_BIN From 4c5d54d3dd111c7608b310d782b27c3d7aa4a45e Mon Sep 17 00:00:00 2001 From: MaksimZhukov Date: Tue, 14 Jan 2020 13:25:54 +0300 Subject: [PATCH 2/4] Move setting of variable --- images/linux/scripts/installers/google-chrome.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/images/linux/scripts/installers/google-chrome.sh b/images/linux/scripts/installers/google-chrome.sh index c37209b0..4918317b 100644 --- a/images/linux/scripts/installers/google-chrome.sh +++ b/images/linux/scripts/installers/google-chrome.sh @@ -41,9 +41,9 @@ rm chromedriver_linux64.zip CHROMEDRIVER_BIN="/usr/bin/chromedriver" mv "chromedriver" $CHROMEDRIVER_BIN -echo "ChromeWebDriver=$CHROMEDRIVER_BIN" | tee -a /etc/environment chown root:root $CHROMEDRIVER_BIN chmod +x $CHROMEDRIVER_BIN +echo "ChromeWebDriver=$CHROMEDRIVER_BIN" | tee -a /etc/environment # Run tests to determine that the chromedriver installed as expected echo "Testing to make sure that script performed as expected, and basic scenarios work" From 50b1638ecbf2ebd7d90d30b7fb2cba595f6b50e1 Mon Sep 17 00:00:00 2001 From: MaksimZhukov Date: Tue, 14 Jan 2020 15:18:45 +0300 Subject: [PATCH 3/4] Change the variable to uppercase --- images/linux/scripts/installers/google-chrome.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/images/linux/scripts/installers/google-chrome.sh b/images/linux/scripts/installers/google-chrome.sh index 4918317b..939ce31b 100644 --- a/images/linux/scripts/installers/google-chrome.sh +++ b/images/linux/scripts/installers/google-chrome.sh @@ -43,7 +43,7 @@ CHROMEDRIVER_BIN="/usr/bin/chromedriver" mv "chromedriver" $CHROMEDRIVER_BIN chown root:root $CHROMEDRIVER_BIN chmod +x $CHROMEDRIVER_BIN -echo "ChromeWebDriver=$CHROMEDRIVER_BIN" | tee -a /etc/environment +echo "CHROMEWEBDRIVER=$CHROMEDRIVER_BIN" | tee -a /etc/environment # Run tests to determine that the chromedriver installed as expected echo "Testing to make sure that script performed as expected, and basic scenarios work" From f5460b3ddd5d2f4ad0ec3983056f135bbe70ed53 Mon Sep 17 00:00:00 2001 From: MaksimZhukov Date: Tue, 14 Jan 2020 18:35:00 +0300 Subject: [PATCH 4/4] Update google-chrome script --- images/linux/scripts/installers/google-chrome.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/images/linux/scripts/installers/google-chrome.sh b/images/linux/scripts/installers/google-chrome.sh index 939ce31b..20396e2a 100644 --- a/images/linux/scripts/installers/google-chrome.sh +++ b/images/linux/scripts/installers/google-chrome.sh @@ -53,7 +53,7 @@ if ! command -v chromedriver; then fi echo "Lastly, documenting what we added to the metadata file" -DocumentInstalledItem "Chromedriver ($(chromedriver --version))" +DocumentInstalledItem "Chromedriver ($(chromedriver --version)); Chrome Driver is available via CHROMEWEBDRIVER environment variable" # Determine latest selenium standalone server version SELENIUM_LATEST_VERSION_URL=https://api.github.com/repos/SeleniumHQ/selenium/releases/latest