From d3ec1c0040d45009d7e2e57d103b982390577c0c Mon Sep 17 00:00:00 2001
From: Nikola Jokic <nikola-jokic@github.com>
Date: Fri, 10 Jun 2022 16:38:07 +0200
Subject: [PATCH] prepare job in k8s does not allow for no job container

---
 packages/k8s/src/hooks/prepare-job.ts  | 4 ++++
 packages/k8s/tests/prepare-job-test.ts | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/packages/k8s/src/hooks/prepare-job.ts b/packages/k8s/src/hooks/prepare-job.ts
index 2362523..e5ecf6a 100644
--- a/packages/k8s/src/hooks/prepare-job.ts
+++ b/packages/k8s/src/hooks/prepare-job.ts
@@ -25,6 +25,10 @@ export async function prepareJob(
   args: prepareJobArgs,
   responseFile
 ): Promise<void> {
+  if (!args.container) {
+    throw new Error('Job Container is required.')
+  }
+
   await prunePods()
   if (!(await isAuthPermissionsOK())) {
     throw new Error(
diff --git a/packages/k8s/tests/prepare-job-test.ts b/packages/k8s/tests/prepare-job-test.ts
index 253f36e..00a5759 100644
--- a/packages/k8s/tests/prepare-job-test.ts
+++ b/packages/k8s/tests/prepare-job-test.ts
@@ -69,10 +69,10 @@ describe('Prepare job', () => {
     ).rejects.toThrow()
   })
 
-  it('should run prepare job without the job container', async () => {
+  it('should not run prepare job without the job container', async () => {
     prepareJobData.args.container = undefined
     await expect(
       prepareJob(prepareJobData.args, prepareJobOutputFilePath)
-    ).resolves.not.toThrow()
+    ).rejects.toThrow()
   })
 })