From aae800a69b7a6a5206971f707e48d0c7d3b680a2 Mon Sep 17 00:00:00 2001 From: Nikola Jokic Date: Wed, 16 Apr 2025 15:57:59 +0200 Subject: [PATCH] bump node in tests to node 22 since node14 is quite old (#216) * bump node in tests to node 22 since node14 is quite old * change test contsants --- examples/prepare-job.json | 2 +- examples/run-container-step.json | 2 +- packages/k8s/tests/k8s-utils-test.ts | 6 +++--- packages/k8s/tests/prepare-job-test.ts | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/prepare-job.json b/examples/prepare-job.json index 8e122d1..fe6abd4 100644 --- a/examples/prepare-job.json +++ b/examples/prepare-job.json @@ -4,7 +4,7 @@ "state": {}, "args": { "container": { - "image": "node:14.16", + "image": "node:22", "workingDirectory": "/__w/repo/repo", "createOptions": "--cpus 1", "environmentVariables": { diff --git a/examples/run-container-step.json b/examples/run-container-step.json index 8c15d4e..b443777 100644 --- a/examples/run-container-step.json +++ b/examples/run-container-step.json @@ -9,7 +9,7 @@ } }, "args": { - "image": "node:14.16", + "image": "node:22", "dockerfile": null, "entryPointArgs": [ "-e", diff --git a/packages/k8s/tests/k8s-utils-test.ts b/packages/k8s/tests/k8s-utils-test.ts index cfe5623..fc84586 100644 --- a/packages/k8s/tests/k8s-utils-test.ts +++ b/packages/k8s/tests/k8s-utils-test.ts @@ -394,7 +394,7 @@ metadata: spec: containers: - name: test - image: node:14.16 + image: node:22 - name: job image: ubuntu:latest` ) @@ -407,7 +407,7 @@ spec: it('should merge container spec', () => { const base = { - image: 'node:14.16', + image: 'node:22', name: 'test', env: [ { @@ -462,7 +462,7 @@ spec: const base = { containers: [ { - image: 'node:14.16', + image: 'node:22', name: 'test', env: [ { diff --git a/packages/k8s/tests/prepare-job-test.ts b/packages/k8s/tests/prepare-job-test.ts index 671294c..18e3683 100644 --- a/packages/k8s/tests/prepare-job-test.ts +++ b/packages/k8s/tests/prepare-job-test.ts @@ -125,7 +125,7 @@ describe('Prepare job', () => { // job container expect(got.spec?.containers[0].name).toBe(JOB_CONTAINER_NAME) - expect(got.spec?.containers[0].image).toBe('node:14.16') + expect(got.spec?.containers[0].image).toBe('node:22') expect(got.spec?.containers[0].command).toEqual(['sh']) expect(got.spec?.containers[0].args).toEqual(['-c', 'sleep 50'])