From a62b81fc956249be0d7fc01d78990f89e703fb35 Mon Sep 17 00:00:00 2001 From: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com> Date: Thu, 15 Dec 2022 14:59:53 +0100 Subject: [PATCH] Update 0034-build-docker-with-kaniko.md --- docs/adrs/0034-build-docker-with-kaniko.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/adrs/0034-build-docker-with-kaniko.md b/docs/adrs/0034-build-docker-with-kaniko.md index 99c3e1c..64fd4e0 100644 --- a/docs/adrs/0034-build-docker-with-kaniko.md +++ b/docs/adrs/0034-build-docker-with-kaniko.md @@ -21,8 +21,9 @@ Whether using dind/docker-in-docker sidecar or Kaniko, in this ADR I will refer ## Interface The user will set `containerMode:kubernetes` since this is a change to the behaviour of our k8s hooks -The user will either -- Provide a port to a (cluster-local) docker registry into which the Kaniko builder container can push the image +The user will +EITHER +- Provide a set of ENVs to a (cluster-local) docker registry into which the Kaniko builder container can push the image - `ACTIONS_RUNNER_CONTAINER_HOOKS_REGISTRY_HOST` # Registry (service) name for kaniko where to push, e.g. 'docker-registry', kaniko pushes to this domain - `ACTIONS_RUNNER_CONTAINER_HOOKS_REGISTRY_PORT` # Container (service) port of the registry, e.g. 5000, kaniko pushes through this port - `ACTIONS_RUNNER_CONTAINER_HOOKS_REGISTRY_NODE_PORT` # NodePort - the K8S job will pull the image from here