From 6c9241fb0e363dbdd8b3e9dc553ec3161b7e38ee Mon Sep 17 00:00:00 2001 From: Ferenc Hammerl Date: Tue, 4 Oct 2022 16:33:41 +0200 Subject: [PATCH] Update 0034-build-docker-with-kaniko.md --- docs/adrs/0034-build-docker-with-kaniko.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/adrs/0034-build-docker-with-kaniko.md b/docs/adrs/0034-build-docker-with-kaniko.md index 4a1b3e9..8f6f0a2 100644 --- a/docs/adrs/0034-build-docker-with-kaniko.md +++ b/docs/adrs/0034-build-docker-with-kaniko.md @@ -21,8 +21,10 @@ Whether using dind/docker-in-docker or Kaniko, in this ADR I will refer to these ## Interface - You will set `containerMode:kubernetes` when creating a runner - this is mandatory as we're only changing the behaviour of our k8s hooks - The user will have to provide a port to a (cluster-local) docker registry into which the Kaniko builder container can push the image - - Currently it is provided using the `ACTIONS_RUNNER_CONTAINER_HOOKS_REGISTRY_NODE_PORT` env var - - The hooks then build up a URI like `localhost:${registryNodePort()}/${generated-random-string-handle-image}` + - `ACTIONS_RUNNER_CONTAINER_HOOKS_REGISTRY_HOST` # Registry (service) name for kaniko where to push, e.g. 'docker-registry', kaniko pushes to this domain + - `ACTIONS_RUNNER_CONTAINER_HOOKS_REGISTRY_PORT` # Container (service) port of the registry, e.g. 5000, kaniko pushes through this port + - `ACTIONS_RUNNER_CONTAINER_HOOKS_REGISTRY_NODE_PORT` # NodePort - the K8S job will pull the image from here + - The hooks then build up a URI like `localhost:${registryNodePort()}/${generated-random-string-handle-image}` for the k8s job to pull from - `localhost` is the current limitation enforcing the existence of a docker registry exposed through the `nodePort` of a k8s service - To execute a container-action, we run a k8s job by loading the image from the specified registry - (TBD) Our hooks will then remove the image from the registry