Fix service port mappings when input is undefined, null, or empty (#60)

* fix: service without ports defined

* fix port mappings when ports are undefined,null or empty

* fix

Co-authored-by: Ronald Claveau <ronald.claveau@pennylane.com>

packages/k8s/src/hooks/prepare-job.ts

@@ -125,10 +125,9 @@ function generateResponseFile(
   )
   if (serviceContainers?.length) {
     response.context['services'] = serviceContainers.map(c => {
-      if (!c.ports) {
+      if (!c.ports?.length) {
-        return
+        return { image: c.image }
       }
-
       const ctxPorts: ContextPorts = {}
       for (const port of c.ports) {
         ctxPorts[port.containerPort] = port.hostPort

packages/k8s/src/k8s/index.ts

@@ -517,6 +517,9 @@ export function containerPorts(
   container: ContainerInfo
 ): k8s.V1ContainerPort[] {
   const ports: k8s.V1ContainerPort[] = []
+  if (!container.portMappings?.length) {
+    return ports
+  }
   for (const portDefinition of container.portMappings) {
     const portProtoSplit = portDefinition.split('/')
     if (portProtoSplit.length > 2) {

packages/k8s/tests/prepare-job-test.ts

@@ -82,4 +82,18 @@ describe('Prepare job', () => {
     expect(services[0].command).toBe(undefined)
     expect(services[0].args).toBe(undefined)
   })
+
+  test.each([undefined, null, []])(
+    'should not throw exception when portMapping=%p',
+    async pm => {
+      prepareJobData.args.services.forEach(s => {
+        s.portMappings = pm
+      })
+      await prepareJob(prepareJobData.args, prepareJobOutputFilePath)
+      const content = JSON.parse(
+        fs.readFileSync(prepareJobOutputFilePath).toString()
+      )
+      expect(() => content.context.services[0].image).not.toThrow()
+    }
+  )
 })