From 3e04b45585beaee9a4f5174d482bb5f351c7a5c5 Mon Sep 17 00:00:00 2001 From: Nikola Jokic Date: Fri, 10 Jun 2022 12:45:59 +0200 Subject: [PATCH] removed leftover todo comments --- packages/docker/src/dockerCommands/container.ts | 2 +- packages/docker/src/hooks/prepare-job.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/docker/src/dockerCommands/container.ts b/packages/docker/src/dockerCommands/container.ts index 89bf737..8e3bc04 100644 --- a/packages/docker/src/dockerCommands/container.ts +++ b/packages/docker/src/dockerCommands/container.ts @@ -149,7 +149,7 @@ export async function containerBuild( dockerArgs.push('-t', tag) dockerArgs.push('-f', args.dockerfile) dockerArgs.push(getBuildContext(args.dockerfile)) - // TODO: figure out build working directory + await runDockerCommand(dockerArgs, { workingDir: getWorkingDir(args.dockerfile) }) diff --git a/packages/docker/src/hooks/prepare-job.ts b/packages/docker/src/hooks/prepare-job.ts index 5be7f9d..599ff97 100644 --- a/packages/docker/src/hooks/prepare-job.ts +++ b/packages/docker/src/hooks/prepare-job.ts @@ -139,7 +139,6 @@ function generateResponseFile( servicesMetadata?: ContainerMetadata[], isAlpine = false ): void { - // todo figure out if we are alpine const response = { state: { network: networkName }, context: {},