fix: use environment variable for PIP_ROOT_USER_ACTION (#265)

* fix: error out on install failure in "Apply build artifact to the local machine" step

* fix: error out on pip installation / update failure

* fix: use environment variable for `PIP_ROOT_USER_ACTION`

This extends the fix from #259 since every platform for 3.8.10 / 3.9.13 has been rebuilt instead of just macOS arm64 being added.

The regression was introduced in #223

.github/workflows/build-python-packages.yml

@@ -123,6 +123,7 @@ jobs:
 
       - name: Apply build artifact to the local machine
         run: |
+          $PSNativeCommandUseErrorActionPreference = $true
           if ('${{ matrix.platform }}' -eq 'win32') {
             powershell ./setup.ps1
             } else {

installers/nix-setup-template.sh

@@ -49,8 +49,9 @@ fi
 chmod +x ../python $PYTHON_MAJOR $PYTHON_MAJOR_DOT_MINOR $PYTHON_MAJORMINOR python
 
 echo "Upgrading pip..."
+export PIP_ROOT_USER_ACTION=ignore
 ./python -m ensurepip
-./python -m pip install --ignore-installed pip --disable-pip-version-check --no-warn-script-location --root-user-action=ignore
+./python -m pip install --ignore-installed pip --disable-pip-version-check --no-warn-script-location
 
 echo "Create complete file"
 touch $PYTHON_TOOLCACHE_VERSION_PATH/x64.complete

installers/win-setup-template.ps1

@@ -133,8 +133,12 @@ if ($MajorVersion -ne "2") {
 }
 
 Write-Host "Install and upgrade Pip"
+$Env:PIP_ROOT_USER_ACTION = "ignore"
 $PythonExePath = Join-Path -Path $PythonArchPath -ChildPath "python.exe"
-cmd.exe /c "$PythonExePath -m ensurepip && $PythonExePath -m pip install --upgrade pip --no-warn-script-location --root-user-action=ignore"
+cmd.exe /c "$PythonExePath -m ensurepip && $PythonExePath -m pip install --upgrade pip --no-warn-script-location"
+if ($LASTEXITCODE -ne 0) {
+    Throw "Error happened during pip installation / upgrade"
+}
 
 Write-Host "Create complete file"
 New-Item -ItemType File -Path $PythonVersionPath -Name "$Architecture.complete" | Out-Null

versions-manifest.json

@@ -3500,46 +3500,45 @@
   {
     "version": "3.9.13",
     "stable": true,
-    "release_url": "https://github.com/actions/python-versions/releases/tag/3.9.13-2717571420",
+    "release_url": "https://github.com/actions/python-versions/releases/tag/3.9.13-8833805153",
     "files": [
+      {
+        "filename": "python-3.9.13-darwin-arm64.tar.gz",
+        "arch": "arm64",
+        "platform": "darwin",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-8833805153/python-3.9.13-darwin-arm64.tar.gz"
+      },
       {
         "filename": "python-3.9.13-darwin-x64.tar.gz",
         "arch": "x64",
         "platform": "darwin",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-2717571420/python-3.9.13-darwin-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-8833805153/python-3.9.13-darwin-x64.tar.gz"
-      },
-      {
-        "filename": "python-3.9.13-linux-18.04-x64.tar.gz",
-        "arch": "x64",
-        "platform": "linux",
-        "platform_version": "18.04",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-2717571420/python-3.9.13-linux-18.04-x64.tar.gz"
       },
       {
         "filename": "python-3.9.13-linux-20.04-x64.tar.gz",
         "arch": "x64",
         "platform": "linux",
         "platform_version": "20.04",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-2717571420/python-3.9.13-linux-20.04-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-8833805153/python-3.9.13-linux-20.04-x64.tar.gz"
       },
       {
         "filename": "python-3.9.13-linux-22.04-x64.tar.gz",
         "arch": "x64",
         "platform": "linux",
         "platform_version": "22.04",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-2717571420/python-3.9.13-linux-22.04-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-8833805153/python-3.9.13-linux-22.04-x64.tar.gz"
       },
       {
         "filename": "python-3.9.13-win32-x64.zip",
         "arch": "x64",
         "platform": "win32",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-2717571420/python-3.9.13-win32-x64.zip"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-8833805153/python-3.9.13-win32-x64.zip"
       },
       {
         "filename": "python-3.9.13-win32-x86.zip",
         "arch": "x86",
         "platform": "win32",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-2717571420/python-3.9.13-win32-x86.zip"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.9.13-8833805153/python-3.9.13-win32-x86.zip"
       }
     ]
   },
@@ -4629,39 +4628,38 @@
   {
     "version": "3.8.10",
     "stable": true,
-    "release_url": "https://github.com/actions/python-versions/releases/tag/3.8.10-117959",
+    "release_url": "https://github.com/actions/python-versions/releases/tag/3.8.10-8833490298",
     "files": [
+      {
+        "filename": "python-3.8.10-darwin-arm64.tar.gz",
+        "arch": "arm64",
+        "platform": "darwin",
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-8833490298/python-3.8.10-darwin-arm64.tar.gz"
+      },
       {
         "filename": "python-3.8.10-darwin-x64.tar.gz",
         "arch": "x64",
         "platform": "darwin",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-117959/python-3.8.10-darwin-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-8833490298/python-3.8.10-darwin-x64.tar.gz"
-      },
-      {
-        "filename": "python-3.8.10-linux-18.04-x64.tar.gz",
-        "arch": "x64",
-        "platform": "linux",
-        "platform_version": "18.04",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-117959/python-3.8.10-linux-18.04-x64.tar.gz"
       },
       {
         "filename": "python-3.8.10-linux-20.04-x64.tar.gz",
         "arch": "x64",
         "platform": "linux",
         "platform_version": "20.04",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-117959/python-3.8.10-linux-20.04-x64.tar.gz"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-8833490298/python-3.8.10-linux-20.04-x64.tar.gz"
       },
       {
         "filename": "python-3.8.10-win32-x64.zip",
         "arch": "x64",
         "platform": "win32",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-117959/python-3.8.10-win32-x64.zip"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-8833490298/python-3.8.10-win32-x64.zip"
       },
       {
         "filename": "python-3.8.10-win32-x86.zip",
         "arch": "x86",
         "platform": "win32",
-        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-117959/python-3.8.10-win32-x86.zip"
+        "download_url": "https://github.com/actions/python-versions/releases/download/3.8.10-8833490298/python-3.8.10-win32-x86.zip"
       }
     ]
   },