From c3a152eec111f5662a31b28aa1d6707effb4585c Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 8 Sep 2023 11:43:56 +0200 Subject: [PATCH 1/2] Add note regarding `pull_request_target` to README.md I think this is a big gotcha that should be called out in the documentation. I've been trying to debug why the workflow did not run for a long time, until I finally understood the underlying issue. --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 5ba6f3e0..478b343a 100644 --- a/README.md +++ b/README.md @@ -240,6 +240,10 @@ permissions documentation](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token) for more details about access levels and event contexts. +## Notes regarding `pull_request_target` + +When submitting a initial pull request to a repository using the `pull_request_target` event, the labeler action will not run on that pull request because the `pull_request_target` execution runs off the base branch instead of the pull request's branch. Unfortunately this means the introduction of the labeler can not be verified during that pull request and it needs to be committed blindly. + ## Contributions Contributions are welcome! See the [Contributor's Guide](CONTRIBUTING.md). From 92c88741709f0b6c68821559aedecd3ccdf195e6 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 8 Sep 2023 11:46:17 +0200 Subject: [PATCH 2/2] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 478b343a..e033b8d7 100644 --- a/README.md +++ b/README.md @@ -242,7 +242,7 @@ for more details about access levels and event contexts. ## Notes regarding `pull_request_target` -When submitting a initial pull request to a repository using the `pull_request_target` event, the labeler action will not run on that pull request because the `pull_request_target` execution runs off the base branch instead of the pull request's branch. Unfortunately this means the introduction of the labeler can not be verified during that pull request and it needs to be committed blindly. +When submitting a initial pull request to a repository using the `pull_request_target` event, the labeler workflow will not run on that pull request because the `pull_request_target` execution runs off the base branch instead of the pull request's branch. Unfortunately this means the introduction of the labeler can not be verified during that pull request and it needs to be committed blindly. ## Contributions