mirror of
https://github.com/actions/add-to-project.git
synced 2025-12-12 13:07:21 +00:00
4afe1bcb60
1. Fixed misleading operator precedence by adding proper grouping: - Changed /^text\/|charset=utf-8$/ to /^(text\/|charset=utf-8)$/ - This removes the misleading precedence warning 2. Fixed file system race condition in fix-regex.js: - Removed fs.existsSync() check followed by file operations - Now uses try/catch with proper ENOENT error handling - Eliminates potential TOCTOU vulnerability All tests pass and regex functionality is preserved.
49 lines
1.7 KiB
JavaScript
49 lines
1.7 KiB
JavaScript
#!/usr/bin/env node
|
||
|
||
/**
|
||
* Fix for misleading operator precedence in @octokit/request regex
|
||
* Changes /^text\/|charset=utf-8$/ to /^(text\/|charset=utf-8)$/
|
||
*/
|
||
|
||
const fs = require('fs')
|
||
|
||
const filesToFix = [
|
||
'node_modules/@actions/github/node_modules/@octokit/request/dist-src/fetch-wrapper.js',
|
||
'node_modules/@actions/github/node_modules/@octokit/request/dist-node/index.js',
|
||
'node_modules/@actions/github/node_modules/@octokit/request/dist-web/index.js',
|
||
]
|
||
|
||
process.stdout.write('🔧 Applying regex fix for @octokit/request...\n')
|
||
|
||
let filesFixed = 0
|
||
|
||
for (const filePath of filesToFix) {
|
||
try {
|
||
let content = fs.readFileSync(filePath, 'utf8')
|
||
const originalContent = content
|
||
|
||
// Fix the problematic regex pattern - add proper grouping to fix operator precedence
|
||
content = content.replace(/\/\^text\\?\/\|charset=utf-8\$?\//g, '/^(text\\/|charset=utf-8)$/')
|
||
content = content.replace(/\/\^text\/\|charset=utf-8\$?\//g, '/^(text/|charset=utf-8)$/')
|
||
|
||
if (content !== originalContent) {
|
||
fs.writeFileSync(filePath, content, 'utf8')
|
||
process.stdout.write(`✅ Fixed: ${filePath}\n`)
|
||
filesFixed++
|
||
} else {
|
||
process.stdout.write(`ℹ️ No changes needed: ${filePath}\n`)
|
||
}
|
||
} catch (error) {
|
||
if (error.code === 'ENOENT') {
|
||
process.stdout.write(`⚠️ File not found: ${filePath}\n`)
|
||
} else {
|
||
process.stderr.write(`❌ Error fixing ${filePath}: ${error.message}\n`)
|
||
}
|
||
}
|
||
}
|
||
|
||
process.stdout.write(`\n🎉 Fix complete! ${filesFixed} files updated.\n`)
|
||
if (filesFixed > 0) {
|
||
process.stdout.write('Run "npm run build:package" to rebuild with the fix.\n')
|
||
}
|