Merge pull request #751 from actions/copilot/update-eslint-dependencies

Consolidate ESLint 9 and TypeScript ESLint 8 dependency updates

.eslintignore

@@ -1,5 +0,0 @@
-dist/
-lib/
-node_modules/
-jest.config.js
-fix-regex.js

.eslintrc.json

@@ -1,26 +0,0 @@
-{
-  "root": true,
-  "parser": "@typescript-eslint/parser",
-  "plugins": ["@typescript-eslint", "github", "jest", "prettier"],
-  "extends": [
-    "plugin:github/recommended",
-    "plugin:@typescript-eslint/eslint-recommended",
-    "plugin:@typescript-eslint/recommended",
-    "prettier"
-  ],
-  "parserOptions": {
-    "ecmaVersion": 2019,
-    "sourceType": "module"
-  },
-  "env": {
-    "node": true,
-    "es6": true,
-    "jest/globals": true
-  },
-  "rules": {
-    "filenames/match-regex": "off",
-    "github/no-then": "off",
-    "i18n-text/no-en": "off",
-    "import/no-namespace": "off"
-  }
-}

.github/workflows/check-dist.yml

@@ -30,7 +30,7 @@ jobs:
       - uses: actions/checkout@v5
 
       - name: Set Node.js 20.x
-        uses: actions/setup-node@v5
+        uses: actions/setup-node@v6
         with:
           node-version: 20.x
           cache: npm
@@ -61,7 +61,7 @@ jobs:
         id: diff
 
       # If index.js was different than expected, upload the expected version as an artifact
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v5
         if: ${{ failure() && steps.diff.conclusion == 'failure' }}
         with:
           name: dist

.github/workflows/codeql-analysis.yml

@@ -42,7 +42,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v3
+        uses: github/codeql-action/init@v4
         with:
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -53,7 +53,7 @@ jobs:
       # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below)
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v3
+        uses: github/codeql-action/autobuild@v4
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 https://git.io/JvXDl
@@ -67,4 +67,4 @@ jobs:
       #   make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v3
+        uses: github/codeql-action/analyze@v4

.licenses/npm/fast-content-type-parse.dep.yml

@@ -6,7 +6,7 @@ summary: Parse HTTP Content-Type header according to RFC 7231
 homepage: https://github.com/fastify/fast-content-type-parse#readme
 license: other
 licenses:
-- sources: LICENSE
+  - sources: LICENSE
     text: |-
       MIT License
 
@@ -32,6 +32,6 @@ licenses:
       LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
       OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
       SOFTWARE.
-- sources: README.md
+  - sources: README.md
     text: Licensed under [MIT](./LICENSE).
 notices: []

README.md

@@ -137,7 +137,6 @@ Using these events ensure that a given issue or pull request, in the workflow's
 ## Creating a PAT and adding it to your repository
 
 - Create a new [personal access token](https://github.com/settings/tokens/new). _See [Creating a personal access token](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token) for more information_
-
   - For **Tokens (classic)** include the `project` scope; for private repos you will also need `repo` scope.
   - For **Fine-grained tokens**, you must first select the appropriate _owner_ and associated _repositories_. Then select _Organization permissions -> `projects` `read & write`_, and _Repository permissions -> `issues` `read-only`_ and _`pull requests` `read-only`_.
 

eslint.config.mjs

@@ -0,0 +1,78 @@
+import eslint from '@eslint/js'
+import tseslint from 'typescript-eslint'
+import github from 'eslint-plugin-github'
+import jest from 'eslint-plugin-jest'
+import globals from 'globals'
+
+export default [
+  // Ignore patterns
+  {
+    ignores: ['dist/**', 'lib/**', 'node_modules/**', '__tests__/fixtures/**', 'eslint.config.mjs'],
+  },
+
+  // Base ESLint recommended rules
+  eslint.configs.recommended,
+
+  // TypeScript ESLint recommended rules
+  ...tseslint.configs.recommended,
+
+  // GitHub plugin recommended rules
+  github.getFlatConfigs().recommended,
+
+  // Configuration for CommonJS JavaScript files
+  {
+    files: ['**/*.js'],
+    languageOptions: {
+      ecmaVersion: 2019,
+      sourceType: 'script',
+      globals: {
+        ...globals.node,
+        ...globals.es6,
+      },
+    },
+    rules: {
+      // Disable specific rules for CommonJS files
+      'github/filenames-match-regex': 'off',
+      'import/no-commonjs': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      'i18n-text/no-en': 'off',
+      'import/no-namespace': 'off',
+      'no-implicit-globals': 'off',
+      'github/no-implicit-buggy-globals': 'off',
+    },
+  },
+
+  // Configuration for TypeScript files
+  {
+    files: ['**/*.ts'],
+    languageOptions: {
+      parser: tseslint.parser,
+      parserOptions: {
+        ecmaVersion: 2019,
+        sourceType: 'module',
+      },
+      globals: {
+        ...globals.node,
+        ...globals.es6,
+      },
+    },
+    rules: {
+      // Disable specific rules as in the original config
+      'github/filenames-match-regex': 'off',
+      'github/no-then': 'off',
+      'i18n-text/no-en': 'off',
+      'import/no-namespace': 'off',
+    },
+  },
+
+  // Jest-specific configuration
+  {
+    files: ['**/*.test.ts', '**/*.test.js', '__tests__/**/*.ts'],
+    ...jest.configs['flat/recommended'],
+    languageOptions: {
+      globals: {
+        ...globals.jest,
+      },
+    },
+  },
+]

fix-regex.js

@@ -41,12 +41,12 @@ function fixFile(filePath) {
 
     if (fixedContent !== originalContent) {
       fs.writeFileSync(filePath, fixedContent, 'utf8')
-            return { fixed: true, error: null }
+      return {fixed: true, error: null}
     } else {
-            return { fixed: false, error: null }
+      return {fixed: false, error: null}
     }
   } catch (error) {
-        return { fixed: false, error: error.message }
+    return {fixed: false, error: error.message}
   }
 }
 
@@ -61,21 +61,21 @@ function fixAllFiles(files = filesToFix) {
 
   for (const filePath of files) {
     const result = fixFile(filePath)
-        results.push({ filePath, ...result })
+    results.push({filePath, ...result})
 
     if (result.fixed) {
       filesFixed++
     }
   }
 
-    return { filesFixed, results }
+  return {filesFixed, results}
 }
 
 // Main execution when run as script
 if (require.main === module) {
   process.stdout.write('🔧 Applying regex fix for @octokit/request...\n')
 
-    const { filesFixed, results } = fixAllFiles()
+  const {filesFixed, results} = fixAllFiles()
 
   for (const result of results) {
     if (result.error) {
@@ -101,5 +101,5 @@ if (require.main === module) {
 module.exports = {
   applyRegexFix,
   fixFile,
-    fixAllFiles
+  fixAllFiles,
 }

package.json

@@ -15,21 +15,24 @@
     "npm": ">= 8.0.0"
   },
   "devDependencies": {
+    "@eslint/js": "^9.39.1",
     "@github/prettier-config": "^0.0.6",
-    "@types/jest": "^29.5.14",
+    "@types/jest": "^30.0.0",
-    "@types/node": "24.5.2",
+    "@types/node": "^24.10.1",
-    "@typescript-eslint/eslint-plugin": "^7.14.1",
+    "@typescript-eslint/eslint-plugin": "^8.47.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/parser": "^8.47.0",
     "@vercel/ncc": "^0.38.3",
     "concurrently": "^9.2.1",
-    "eslint": "^8.57.0",
+    "eslint": "^9.39.1",
-    "eslint-plugin-github": "^5.0.1",
+    "eslint-plugin-github": "^6.0.0",
-    "eslint-plugin-jest": "^28.11.0",
+    "eslint-plugin-jest": "^29.1.0",
     "eslint-plugin-prettier": "^5.2.5",
-    "jest": "^29.7.0",
+    "globals": "^15.14.0",
+    "jest": "^30.2.0",
     "prettier": "3.6.2",
-    "ts-jest": "^29.4.0",
+    "ts-jest": "^29.4.5",
-    "typescript": "^5.5.2"
+    "typescript": "^5.9.3",
+    "typescript-eslint": "^8.47.0"
   },
   "keywords": [
     "actions",