mirror of
https://github.com/actions/actions-runner-controller.git
synced 2025-12-11 03:57:01 +00:00
f8dffab19d
* Add workflow for validating runner scripts with shellcheck I am about to revisit #1517, #1454, #1561, and #1560 as a part of our on-going effort to a major enhancement to the runner entrypoints being made in #1759. This change is a counterpart of #1852. #1852 enables you to easily run shellcheck locally. This enables you to automatically run shellcheck on every pull request. Currently, any shellcheck error does not result in failing the workflow job. Once we addressed all the shellcheck findings, we can flip the fail_on_error option to true and let jobs start failing on pull requests that introduce invalid or suspicious bash code.
47 lines
1.1 KiB
YAML
47 lines
1.1 KiB
YAML
name: Validate Runners
|
|
|
|
on:
|
|
pull_request:
|
|
branches:
|
|
- '**'
|
|
paths:
|
|
- 'runner/**'
|
|
- 'test/entrypoint/**'
|
|
- '!**.md'
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
shellcheck:
|
|
name: runner / shellcheck
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v1
|
|
- name: shellcheck
|
|
uses: reviewdog/action-shellcheck@v1
|
|
with:
|
|
github_token: ${{ secrets.GITHUB_TOKEN }}
|
|
reporter: shellcheck
|
|
path: "./runner"
|
|
pattern: |
|
|
*.sh
|
|
*.bash
|
|
update-status
|
|
# Make this consistent with `make shellsheck`
|
|
shellcheck_flags: "--shell bash --source-path runner"
|
|
exclude: "./.git/*"
|
|
check_all_files_with_shebangs: "false"
|
|
# Set this to "true" once we addressed all the shellcheck findings
|
|
fail_on_error: "false"
|
|
test-runner-entrypoint:
|
|
name: Test entrypoint
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v3
|
|
|
|
- name: Run tests
|
|
run: |
|
|
make acceptance/runner/entrypoint
|