actions/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions/actions-runner-controller.git synced 2026-01-18 01:33:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rename Id and Url fields to ID and URL per convention

Browse Source
This commit is contained in:
Nikola Jokic
2026-01-15 19:16:07 +01:00
parent 0bb603edc8
commit ffcaa06b6a
26 changed files with 193 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
controllers/actions.github.com/secret_resolver.go
View File

@@ -45,7 +45,7 @@ func NewSecretResolver(k8sClient client.Client, multiClient actions.MultiClient,
type ActionsGitHubObject interface {
client.Object
GitHubConfigUrl() string
GitHubConfigURL() string
GitHubConfigSecret() string
GitHubProxy() *v1alpha1.ProxyConfig
GitHubServerTLS() *v1alpha1.TLSConfig
@@ -85,9 +85,9 @@ func (sr *SecretResolver) GetActionsService(ctx context.Context, obj ActionsGitH
}
if proxy.HTTP != nil {
u, err := url.Parse(proxy.HTTP.Url)
u, err := url.Parse(proxy.HTTP.URL)
if err != nil {
return nil, fmt.Errorf("failed to parse proxy http url %q: %w", proxy.HTTP.Url, err)
return nil, fmt.Errorf("failed to parse proxy http url %q: %w", proxy.HTTP.URL, err)
}
if ref := proxy.HTTP.CredentialSecretRef; ref != "" {
@@ -101,9 +101,9 @@ func (sr *SecretResolver) GetActionsService(ctx context.Context, obj ActionsGitH
}
if proxy.HTTPS != nil {
u, err := url.Parse(proxy.HTTPS.Url)
u, err := url.Parse(proxy.HTTPS.URL)
if err != nil {
return nil, fmt.Errorf("failed to parse proxy https url %q: %w", proxy.HTTPS.Url, err)
return nil, fmt.Errorf("failed to parse proxy https url %q: %w", proxy.HTTPS.URL, err)
}
if ref := proxy.HTTPS.CredentialSecretRef; ref != "" {
@@ -150,7 +150,7 @@ func (sr *SecretResolver) GetActionsService(ctx context.Context, obj ActionsGitH
return sr.multiClient.GetClientFor(
ctx,
obj.GitHubConfigUrl(),
obj.GitHubConfigURL(),
appConfig,
obj.GetNamespace(),
clientOptions...,