actions/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions/actions-runner-controller.git synced 2025-12-12 04:26:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix integration test bugs and do verify scaling out

Browse Source
This commit is contained in:
Yusuke Kuoka
2020-08-02 10:34:58 +09:00
parent 3c3077a11c
commit e2164f9946
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
controllers/integration_test.go
View File

@@ -29,6 +29,9 @@ func SetupIntegrationTest(ctx context.Context) *corev1.Namespace {
var stopCh chan struct{} var stopCh chan struct{}
ns := &corev1.Namespace{} ns := &corev1.Namespace{}
workflowRuns := `{"total_count": 5, "workflow_runs":[{"status":"queued"}, {"status":"queued"}, {"status":"in_progress"}, {"status":"in_progress"}, {"status":"completed"}]}"`
server := fake.NewServer(fake.WithListRepositoryWorkflowRunsResponse(200, workflowRuns))
BeforeEach(func() { BeforeEach(func() {
stopCh = make(chan struct{}) stopCh = make(chan struct{})
*ns = corev1.Namespace{ *ns = corev1.Namespace{
@@ -59,10 +62,6 @@ func SetupIntegrationTest(ctx context.Context) *corev1.Namespace {
err = deploymentsController.SetupWithManager(mgr) err = deploymentsController.SetupWithManager(mgr)
Expect(err).NotTo(HaveOccurred(), "failed to setup controller") Expect(err).NotTo(HaveOccurred(), "failed to setup controller")
workflowRuns := `{"total_count": 4, "workflow_runs":[{"status":"in_progress"}, {"status":"in_progress"}, {"status":"in_progress"}, {"status":"completed"}]}"`
server := fake.NewServer(fake.WithListRepositoryWorkflowRunsResponse(200, workflowRuns))
defer server.Close()
client := newGithubClient(server) client := newGithubClient(server)
autoscalerController := &HorizontalRunnerAutoscalerReconciler{ autoscalerController := &HorizontalRunnerAutoscalerReconciler{
@@ -86,6 +85,8 @@ func SetupIntegrationTest(ctx context.Context) *corev1.Namespace {
AfterEach(func() { AfterEach(func() {
close(stopCh) close(stopCh)
server.Close()
err := k8sClient.Delete(ctx, ns) err := k8sClient.Delete(ctx, ns)
Expect(err).NotTo(HaveOccurred(), "failed to delete test namespace") Expect(err).NotTo(HaveOccurred(), "failed to delete test namespace")
}) })
@@ -112,7 +113,7 @@ var _ = Context("Inside of a new namespace", func() {
Replicas: intPtr(1), Replicas: intPtr(1),
Template: actionsv1alpha1.RunnerTemplate{ Template: actionsv1alpha1.RunnerTemplate{
Spec: actionsv1alpha1.RunnerSpec{ Spec: actionsv1alpha1.RunnerSpec{
Repository: "foo/bar", Repository: "test/valid",
Image: "bar", Image: "bar",
Env: []corev1.EnvVar{ Env: []corev1.EnvVar{
{Name: "FOO", Value: "FOOVALUE"}, {Name: "FOO", Value: "FOOVALUE"},
@@ -209,7 +210,7 @@ var _ = Context("Inside of a new namespace", func() {
Name: name, Name: name,
}, },
MinReplicas: intPtr(1), MinReplicas: intPtr(1),
MaxReplicas: intPtr(2), MaxReplicas: intPtr(3),
ScaleDownDelaySecondsAfterScaleUp: nil, ScaleDownDelaySecondsAfterScaleUp: nil,
Metrics: nil, Metrics: nil,
}, },
@@ -246,7 +247,7 @@ var _ = Context("Inside of a new namespace", func() {
return *runnerSets.Items[0].Spec.Replicas return *runnerSets.Items[0].Spec.Replicas
}, },
time.Second*5, time.Millisecond*500).Should(BeEquivalentTo(1)) time.Second*5, time.Millisecond*500).Should(BeEquivalentTo(3))
} }
}) })
}) })