actions/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions/actions-runner-controller.git synced 2025-12-11 03:57:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Print Version Number on startup (#1659)

Browse Source 
* Changed Dockerfile to get the Enviroment variable from the github actions workflow and pass it to the main.go file

Added a function in main.go to fetch the enviroment varible and to have a fallback if the env variable isnt there

Added a test for the version to use for this branch only

* Update test-version.yaml

* Update test-version.yaml

* Removed the test because its not needed when we push upstream

* Moved the version print in main.go to the Log codeblock as requested by toast-gear

Added version as issue#1161 requests.

Decided to use a docker tag structure for the userAgent string, with : being a seperator of the name and version

* Used ldflags instead like mumoshu recommended

Changed Dockerfile to use $VERSION from the workflow

Added version.go and the build package
Removed the getVersion function as we can just get the value directly

* Used ldflags instead like mumoshu recommended

Changed Dockerfile to use $VERSION from the workflow

Added version.go and the build package
Removed the getVersion function as we can just get the value directly

* * Removed the default from the go code (set it as N/A)
* Changed version from latest to dev inside makefile
* Added buildarg for version to the dockerfile in the makerfile
* Added VERSION with default dev value as arg inside dockerfile
* Cleaned up inside dockerfile

* Fix failing test

* Fix possible missing VERSION in the ARC UA suffix due to missing build arg in docker-build-push step

Co-authored-by: S8338C <viktor.lindgren@seb.se>
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
This commit is contained in:
Viktor Lindgren
2022-08-23 06:40:16 +02:00
committed by GitHub
parent f0c8c07428
commit ca97f39fcb
8 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
main.go
View File

@@ -19,6 +19,7 @@ package main
import (
"flag"
"fmt"
"github.com/actions-runner-controller/actions-runner-controller/build"
"os"
"strings"
"time"
@@ -62,7 +63,6 @@ func (i *stringSlice) Set(value string) error {
*i = append(*i, value)
return nil
}
func main() {
var (
err error
@@ -87,7 +87,6 @@ func main() {
commonRunnerLabels commaSeparatedStringSlice
)
var c github.Config
err = envconfig.Process("github", &c)
if err != nil {
@@ -122,7 +121,6 @@ func main() {
flag.Parse()
logger := logging.NewLogger(logLevel)
c.Log = &logger
ghClient, err = c.NewClient()
@@ -214,6 +212,7 @@ func main() {
log.Info(
"Initializing actions-runner-controller",
"version", build.Version,
"default-scale-down-delay", defaultScaleDownDelay,
"sync-period", syncPeriod,
"default-runner-image", runnerImage,