actions/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions/actions-runner-controller.git synced 2026-01-09 03:29:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

runner: Expose dind runner dockerd logs via stdout/stderr (#2082)

Browse Source 
* runner: Expose dind runner dockerd logs via stdout/stderr

We've been letting supervisord to run dockerd within the dind runner container presuming it would avoid producing zombie processes. However we used dumb-init to wrap supervisord to wrap dockerd. In this picture supervisord might be unnecessary and dumb-init is actually a correct pid 0 for containers.

Rmoving supervisord removes this unnecessary complexity, while saving a little memory, and more importantly logs from dockerd is exposed via stdout/stderr of the container for easy access from kubectl-logs, fluentd, and so on.
This commit is contained in:
Yusuke Kuoka
2022-12-12 08:39:35 +09:00
committed by GitHub
parent 418f719bdf
commit acbce4b70a
6 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runner/actions-runner-dind.ubuntu-22.04.dockerfile
View File

@@ -23,7 +23,6 @@ RUN apt-get update -y \
git-lfs \
iptables \
jq \
supervisor \
software-properties-common \
sudo \
unzip \
@@ -89,7 +88,6 @@ RUN export ARCH=$(echo ${TARGETPLATFORM} | cut -d / -f2) \
# We place the scripts in `/usr/bin` so that users who extend this image can
# override them with scripts of the same name placed in `/usr/local/bin`.
COPY entrypoint-dind.sh startup.sh logger.sh wait.sh graceful-stop.sh update-status /usr/bin/
COPY supervisor/ /etc/supervisor/conf.d/
RUN chmod +x /usr/bin/entrypoint-dind.sh /usr/bin/startup.sh
# Copy the docker shim which propagates the docker MTU to underlying networks