actions/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions/actions-runner-controller.git synced 2026-01-05 01:07:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

runner: Expose dind runner dockerd logs via stdout/stderr (#2082)

Browse Source 
* runner: Expose dind runner dockerd logs via stdout/stderr

We've been letting supervisord to run dockerd within the dind runner container presuming it would avoid producing zombie processes. However we used dumb-init to wrap supervisord to wrap dockerd. In this picture supervisord might be unnecessary and dumb-init is actually a correct pid 0 for containers.

Rmoving supervisord removes this unnecessary complexity, while saving a little memory, and more importantly logs from dockerd is exposed via stdout/stderr of the container for easy access from kubectl-logs, fluentd, and so on.
This commit is contained in:
Yusuke Kuoka
2022-12-12 08:39:35 +09:00
committed by GitHub
parent 418f719bdf
commit acbce4b70a
6 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
runner/actions-runner-dind-rootless.ubuntu-20.04.dockerfile
View File

@@ -41,7 +41,6 @@ RUN apt-get update -y \
python3-pip \
rsync \
shellcheck \
supervisor \
software-properties-common \
sudo \
telnet \