actions/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions/actions-runner-controller.git synced 2025-12-10 11:41:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

EphemeralRunner: On cleanup, if pod is pending, delete from service (#2255)

Browse Source 
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
This commit is contained in:
Nikola Jokic
2023-02-12 01:55:12 +01:00
committed by GitHub
parent 9990243520
commit 8e52a6d2cf
2 changed files with 68 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
controllers/actions.github.com/ephemeralrunner_controller_test.go
View File

@@ -153,19 +153,21 @@ var _ = Describe("EphemeralRunner", func() {
created := new(v1alpha1.EphemeralRunner)
// Check if finalizer is added
Eventually(
func() (string, error) {
func() ([]string, error) {
err := k8sClient.Get(ctx, client.ObjectKey{Name: ephemeralRunner.Name, Namespace: ephemeralRunner.Namespace}, created)
if err != nil {
return "", err
return nil, err
}
if len(created.Finalizers) == 0 {
return "", nil
return nil, nil
}
return created.Finalizers[0], nil
n := len(created.Finalizers) // avoid capacity mismatch
return created.Finalizers[:n:n], nil
},
timeout,
interval,
).Should(BeEquivalentTo(ephemeralRunnerFinalizerName))
).Should(BeEquivalentTo([]string{ephemeralRunnerActionsFinalizerName, ephemeralRunnerFinalizerName}))
Eventually(
func() (bool, error) {