From 7a7086e7aa14848ec19fe3a9ed6b1f97277397f2 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Thu, 18 Mar 2021 10:26:21 +0900 Subject: [PATCH] Make error logs more helpful --- controllers/runner_controller.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/controllers/runner_controller.go b/controllers/runner_controller.go index 3b7f109a..ff2d31ff 100644 --- a/controllers/runner_controller.go +++ b/controllers/runner_controller.go @@ -369,7 +369,7 @@ func (r *RunnerReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) { updated.Status.LastRegistrationCheckTime = &metav1.Time{Time: time.Now()} if err := r.Status().Patch(ctx, updated, client.MergeFrom(&runner)); err != nil { - log.Error(err, "Failed to update runner status") + log.Error(err, "Failed to update runner status for LastRegistrationCheckTime") return ctrl.Result{}, err } @@ -391,7 +391,7 @@ func (r *RunnerReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) { updated.Status.Message = pod.Status.Message if err := r.Status().Patch(ctx, updated, client.MergeFrom(&runner)); err != nil { - log.Error(err, "Failed to update runner status") + log.Error(err, "Failed to update runner status for Phase/Reason/Message") return ctrl.Result{}, err } } @@ -464,7 +464,7 @@ func (r *RunnerReconciler) updateRegistrationToken(ctx context.Context, runner v } if err := r.Status().Update(ctx, updated); err != nil { - log.Error(err, "Failed to update runner status") + log.Error(err, "Failed to update runner status for Registration") return false, err }