actions/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions/actions-runner-controller.git synced 2025-12-11 03:57:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix panic on scaling organizational runners (#381)

Browse Source 
Ref https://github.com/summerwind/actions-runner-controller/issues/377#issuecomment-793287133
This commit is contained in:
Yusuke Kuoka
2021-03-09 15:03:47 +09:00
committed by GitHub
parent c0b8f9d483
commit 728829be7b
2 changed files with 94 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
controllers/autoscaling.go
View File

@@ -91,6 +91,13 @@ func (r *HorizontalRunnerAutoscalerReconciler) calculateReplicasByQueuedAndInPro
return nil, fmt.Errorf("asserting runner deployment spec to detect bug: spec.template.organization should not be empty on this code path")
}
// In case it's an organizational runners deployment without any scaling metrics defined,
// we assume that the desired replicas should always be `minReplicas + capacityReservedThroughWebhook`.
// See https://github.com/summerwind/actions-runner-controller/issues/377#issuecomment-793372693
if len(metrics) == 0 {
return hra.Spec.MinReplicas, nil
}
if len(metrics[0].RepositoryNames) == 0 {
return nil, errors.New("validating autoscaling metrics: spec.autoscaling.metrics[].repositoryNames is required and must have one more more entries for organizational runner deployment")
}