actions/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions/actions-runner-controller.git synced 2025-12-11 03:57:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Avoid duplicate volume and mount name error for generic ephemeral volume as "work" (#1471)

Browse Source 
* fix: Avoid duplicate volume and mount name error for generic ephemeral volume as "work"

While manually testing configurations being documented in #1464, I discovered that the use of dynamic ephemeral volume for "work" directory was not working correctly due to the valiadation error.

This fixes the runner pod generation logic to not add the default volume and volume mount for "work" dir, so that the error disappears.

Ref #1464

* e2e: Ensure work generic ephemeral volume to work as expected
This commit is contained in:
Yusuke Kuoka
2022-05-22 10:25:50 +09:00
committed by GitHub
parent 5bbea772f7
commit 63be0223ad
4 changed files with 163 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/e2e/e2e_test.go
View File

@@ -36,21 +36,21 @@ var (
EnableBuildX: true,
},
{
Dockerfile: "../../runner/Dockerfile",
Dockerfile: "../../runner/actions-runner.dockerfile",
Args: []testing.BuildArg{
{
Name: "RUNNER_VERSION",
Value: "2.289.2",
Value: "2.291.1",
},
},
Image: runnerImage,
},
{
Dockerfile: "../../runner/Dockerfile.dindrunner",
Dockerfile: "../../runner/actions-runner-dind.dockerfile",
Args: []testing.BuildArg{
{
Name: "RUNNER_VERSION",
Value: "2.289.2",
Value: "2.291.1",
},
},
Image: runnerDindImage,