Remove legacy GitHub API cache of HRA.Status.CachedEntries (#1192)

* Remove legacy GitHub API cache of HRA.Status.CachedEntries

We migrated to the transport-level cache introduced in #1127 so not only this is useless, it is harder to deduce which cache resulted in the desired replicas number calculated by HRA.
Just remove the legacy cache to keep it simple and easy to understand.

* Deprecate githubAPICacheDuration helm chart value and the --github-api-cache-duration as well

* Fix integration test
This commit is contained in:
Yusuke Kuoka
2022-03-08 19:05:43 +09:00
committed by GitHub
parent 301439b06a
commit 55ff4de79a
8 changed files with 15 additions and 172 deletions

View File

@@ -13,6 +13,7 @@ enableLeaderElection: true
# Must be unique if more than one controller installed onto the same namespace.
#leaderElectionId: "actions-runner-controller"
# DEPRECATED: This has been removed as unnecessary in #1192
# The controller tries its best not to repeat the duplicate GitHub API call
# within this duration.
# Defaults to syncPeriod - 10s.