Do not enable TotalNumberOfQueuedAndInProgressWorkflowRuns by default (#1372)

Previously, omitting hra.spec.metrics at all resulted in ARC enabling the TotalNumberOfQueuedAndInProgressWorkflowRuns.
That turned out not a good idea so since this change it is not enabled by default.

Ref https://github.com/actions-runner-controller/actions-runner-controller/issues/728
This commit is contained in:
Yusuke Kuoka
2022-04-24 13:36:42 +09:00
committed by GitHub
parent e7c6c26266
commit 3ba7179995
2 changed files with 7 additions and 4 deletions

View File

@@ -221,6 +221,11 @@ func TestDetermineDesiredReplicas_RepositoryRunner(t *testing.T) {
Spec: v1alpha1.HorizontalRunnerAutoscalerSpec{
MaxReplicas: tc.max,
MinReplicas: tc.min,
Metrics: []v1alpha1.MetricSpec{
{
Type: "TotalNumberOfQueuedAndInProgressWorkflowRuns",
},
},
},
Status: v1alpha1.HorizontalRunnerAutoscalerStatus{
DesiredReplicas: tc.sReplicas,