From 271a4dcd9dd3b90539170acd44cae30c2d246351 Mon Sep 17 00:00:00 2001 From: apr-1985 Date: Sun, 17 Oct 2021 23:23:31 +0100 Subject: [PATCH] Revert "chore: support app ids as int or strings (#869)" (#883) * Revert "chore: support app ids as int or strings (#869)" This reverts commit 0a3d2b686e72ec78d578671bf5305d1183701c7b. * docs: adding some comments to the code * docs: adding comment to the chart values --- .../templates/manager_secrets.yaml | 6 ++++-- charts/actions-runner-controller/values.yaml | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/charts/actions-runner-controller/templates/manager_secrets.yaml b/charts/actions-runner-controller/templates/manager_secrets.yaml index acdc6a13..dc3d259c 100644 --- a/charts/actions-runner-controller/templates/manager_secrets.yaml +++ b/charts/actions-runner-controller/templates/manager_secrets.yaml @@ -13,10 +13,12 @@ metadata: type: Opaque data: {{- if .Values.authSecret.github_app_id }} - github_app_id: {{ .Values.authSecret.github_app_id | int | toString | b64enc }} + # Keep this as a string as strings integrate better with things like AWS Parameter Store, see PR #882 for an example + github_app_id: {{ .Values.authSecret.github_app_id | toString | b64enc }} {{- end }} {{- if .Values.authSecret.github_app_installation_id }} - github_app_installation_id: {{ .Values.authSecret.github_app_installation_id | int | toString | b64enc }} + # Keep this as a string as strings integrate better with things like AWS Parameter Store, see PR #882 for an example + github_app_installation_id: {{ .Values.authSecret.github_app_installation_id | toString | b64enc }} {{- end }} {{- if .Values.authSecret.github_app_private_key }} github_app_private_key: {{ .Values.authSecret.github_app_private_key | toString | b64enc }} diff --git a/charts/actions-runner-controller/values.yaml b/charts/actions-runner-controller/values.yaml index 3b8939fa..a0ec7f3b 100644 --- a/charts/actions-runner-controller/values.yaml +++ b/charts/actions-runner-controller/values.yaml @@ -27,7 +27,8 @@ authSecret: create: false name: "controller-manager" annotations: {} - ### GitHub App Configuration + ### GitHub Apps Configuration + ## NOTE: IDs MUST be strings, use quotes #github_app_id: "" #github_app_installation_id: "" #github_app_private_key: |