diff --git a/charts/actions-runner-controller/templates/manager_secrets.yaml b/charts/actions-runner-controller/templates/manager_secrets.yaml index acdc6a13..dc3d259c 100644 --- a/charts/actions-runner-controller/templates/manager_secrets.yaml +++ b/charts/actions-runner-controller/templates/manager_secrets.yaml @@ -13,10 +13,12 @@ metadata: type: Opaque data: {{- if .Values.authSecret.github_app_id }} - github_app_id: {{ .Values.authSecret.github_app_id | int | toString | b64enc }} + # Keep this as a string as strings integrate better with things like AWS Parameter Store, see PR #882 for an example + github_app_id: {{ .Values.authSecret.github_app_id | toString | b64enc }} {{- end }} {{- if .Values.authSecret.github_app_installation_id }} - github_app_installation_id: {{ .Values.authSecret.github_app_installation_id | int | toString | b64enc }} + # Keep this as a string as strings integrate better with things like AWS Parameter Store, see PR #882 for an example + github_app_installation_id: {{ .Values.authSecret.github_app_installation_id | toString | b64enc }} {{- end }} {{- if .Values.authSecret.github_app_private_key }} github_app_private_key: {{ .Values.authSecret.github_app_private_key | toString | b64enc }} diff --git a/charts/actions-runner-controller/values.yaml b/charts/actions-runner-controller/values.yaml index 3b8939fa..a0ec7f3b 100644 --- a/charts/actions-runner-controller/values.yaml +++ b/charts/actions-runner-controller/values.yaml @@ -27,7 +27,8 @@ authSecret: create: false name: "controller-manager" annotations: {} - ### GitHub App Configuration + ### GitHub Apps Configuration + ## NOTE: IDs MUST be strings, use quotes #github_app_id: "" #github_app_installation_id: "" #github_app_private_key: |