From 186c98cf3666354525b203a645025dd7df3e0441 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Mon, 7 Nov 2022 19:01:03 +0900 Subject: [PATCH] ci: Fix runner builds for pull requests coming from "master" branches of forks (#1983) * ci: Fix runner builds but not pushes for forks I noticed that our runners workflow is failing on docker-login due to that a pull request workflow job from a fork does not have access to repo secrets. https://github.com/malachiobadeyi/actions-runner-controller/actions/runs/3390463793/jobs/5634638183 Can we try this, so that hopefully it suppresses docker-login for pull requests from forks? * Update .github/workflows/runners.yaml * fixup! Update .github/workflows/runners.yaml Signed-off-by: Yusuke Kuoka * fixup! fixup! Update .github/workflows/runners.yaml Signed-off-by: Yusuke Kuoka Signed-off-by: Yusuke Kuoka --- .github/actions/setup-docker-environment/action.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/setup-docker-environment/action.yaml b/.github/actions/setup-docker-environment/action.yaml index e27d7f32..2418fdd4 100644 --- a/.github/actions/setup-docker-environment/action.yaml +++ b/.github/actions/setup-docker-environment/action.yaml @@ -32,14 +32,14 @@ runs: version: latest - name: Login to DockerHub - if: ${{ github.event_name == 'release' || github.event_name == 'push' && github.ref == 'refs/heads/master' }} + if: ${{ github.event_name == 'release' || github.event_name == 'push' && github.ref == 'refs/heads/master' && inputs.password != '' }} uses: docker/login-action@v2 with: username: ${{ inputs.username }} password: ${{ inputs.password }} - name: Login to GitHub Container Registry - if: ${{ github.event_name == 'release' || github.event_name == 'push' && github.ref == 'refs/heads/master' }} + if: ${{ github.event_name == 'release' || github.event_name == 'push' && github.ref == 'refs/heads/master' && inputs.ghcr_password != '' }} uses: docker/login-action@v2 with: registry: ghcr.io